Skip to content

fix(core): use file:// URLs for local dynamic import() on Windows+Node #23639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hona merged 2 commits into from
Apr 21, 2026
Merged

fix(core): use file:// URLs for local dynamic import() on Windows+Node #23639

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d5218f
fix(core): use file:// URLs for dynamic import() on Windows+Node
Hona Apr 21, 2026
ba5e2f4
docs(core): clarify local path import comments
Hona Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/opencode/src/provider/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { zod } from "@/util/effect-zod"
import { iife } from "@/util/iife"
import { Global } from "../global"
import path from "path"
import { pathToFileURL } from "url"
import { Effect, Layer, Context, Schema, Types } from "effect"
import { EffectBridge } from "@/effect"
import { InstanceState } from "@/effect"
Expand Down Expand Up @@ -1506,7 +1507,10 @@ const layer: Layer.Layer<
installedPath = model.api.npm
}

const mod = await import(installedPath)
// Node's ESM loader on Windows rejects bare absolute paths; dynamic import() needs
// a file:// URL. Bun accepts both, so this conversion is safe on either runtime.
const importSpec = installedPath.startsWith("file://") ? installedPath : pathToFileURL(installedPath).href
const mod = await import(importSpec)

const fn = mod[Object.keys(mod).find((key) => key.startsWith("create"))!]
const loaded = fn({
Expand Down
6 changes: 3 additions & 3 deletions packages/opencode/src/tool/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,9 @@ export const layer: Layer.Layer<
if (matches.length) yield* config.waitForDependencies()
for (const match of matches) {
const namespace = path.basename(match, path.extname(match))
const mod = yield* Effect.promise(
() => import(process.platform === "win32" ? match : pathToFileURL(match).href),
)
// Node's ESM loader on Windows rejects bare absolute paths; dynamic import()
// needs a file:// URL. Bun accepts both, so this is safe on either runtime.
const mod = yield* Effect.promise(() => import(pathToFileURL(match).href))
for (const [id, def] of Object.entries<ToolDefinition>(mod)) {
custom.push(fromPlugin(id === "default" ? namespace : `${namespace}_${id}`, def))
}
Expand Down
Loading