fix(snapshot): avoid ENAMETOOLONG and improve staging perf via stdin pathspecs - #22560
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the snapshot gitignore-filtering implementation to avoid command-line length limits (ENAMETOOLONG) by passing large file lists to git via stdin, and adds a regression test to cover large tracked sets.
Changes:
- Add stdin support to the internal
git(...)helper and introduce helpers to feed NUL-delimited file lists. - Switch
git check-ignoreandgit rm --cachedcalls to use--stdin -z/--pathspec-from-file=- --pathspec-file-nul. - Add a snapshot test that exercises gitignore filtering with a large number of tracked files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/opencode/src/snapshot/index.ts | Uses stdin-fed NUL-delimited file lists for check-ignore and rm to prevent ENAMETOOLONG. |
| packages/opencode/test/snapshot/snapshot.test.ts | Adds a regression test ensuring large tracked sets are filtered correctly without hitting argv limits. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/review |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the snapshot subsystem’s Git interactions to avoid command-line length limits by passing path lists via stdin, improving reliability for large change sets.
Changes:
- Add a reusable stdin feeder (
feed) and extend the localgit()helper to acceptstdin. - Replace
git check-ignore -- <files…>withgit check-ignore --stdin -zand centralize ignore handling inignore(). - Replace
git rm/add -- <files…>flows with--pathspec-from-file=- --pathspec-file-nuland stage only the candidate set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { concurrency: 8 }, | ||
| )).filter((item): item is string => Boolean(item)), | ||
| ) | ||
| yield* sync(Array.from(large)) |
Comment on lines
+162
to
+170
| const stage = Effect.fnUntraced(function* (files: string[]) { | ||
| if (!files.length) return | ||
| const result = yield* git( | ||
| [...cfg, ...args(["add", "--all", "--sparse", "--pathspec-from-file=-", "--pathspec-file-nul"])], | ||
| { | ||
| cwd: state.directory, | ||
| stdin: feed(files), | ||
| }, | ||
| ) |
Hona
changed the title
Hona
enabled auto-merge (squash)
April 15, 2026 06:41
This was referenced Apr 15, 2026
jwcrystal
pushed a commit
to jwcrystal/opencode
that referenced
this pull request
Apr 15, 2026
cmaloney111
pushed a commit
to psi-oss/gpd-app
that referenced
this pull request
Apr 20, 2026
sdeonvacation
pushed a commit
to sdeonvacation/opencode-x-old
that referenced
this pull request
Apr 23, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
isaacfinnegan
pushed a commit
to isaacfinnegan/whispercode
that referenced
this pull request
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.