refactor(file-time): effectify FileTimeService with Semaphore locks#17835
Merged
kitlangton merged 4 commits intodevfrom Mar 16, 2026
Merged
refactor(file-time): effectify FileTimeService with Semaphore locks#17835kitlangton merged 4 commits intodevfrom
kitlangton merged 4 commits intodevfrom
Conversation
7 tests covering: timestamp recording, session scoping, assert on unread/unchanged/modified files, and withLock serialization. All pass against the current Instance.state implementation.
Convert FileTime from Instance.state to Effect ServiceMap.Service. Replace hand-rolled Promise lock chain with SynchronizedRef<Map> + Semaphore.withPermits for per-file mutual exclusion. Legacy facade preserved — callers unchanged.
kitlangton
added a commit
that referenced
this pull request
Mar 16, 2026
ConanXu-math
pushed a commit
to ConanXu-math/opencode
that referenced
this pull request
Mar 17, 2026
3 tasks
AvatarGanymede
pushed a commit
to AvatarGanymede/opencode-dev
that referenced
this pull request
Mar 19, 2026
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 19, 2026
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 20, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instance.stateto an EffectServiceMap.Serviceon the Instances LayerMapSemaphore.makeUnsafe+withPermitsfor per-file mutual exclusionread,get,assert,withLocksignatures unchanged)Restacked from #17640 onto
devafter parent merge.Testing
bun run test test/file/time.test.tsbunx tsgo --noEmit