refactor(format): effectify FormatService as scoped service#17675
Merged
kitlangton merged 2 commits intodevfrom Mar 16, 2026
Merged
refactor(format): effectify FormatService as scoped service#17675kitlangton merged 2 commits intodevfrom
kitlangton merged 2 commits intodevfrom
Conversation
kitlangton
force-pushed
the
effectify-env-filetime
branch
from
434173a to
70d22b8
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
56d5cb3 to
f173504
Compare
kitlangton
force-pushed
the
effectify-env-filetime
branch
from
70d22b8 to
86aa331
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
f173504 to
07c391f
Compare
kitlangton
force-pushed
the
effectify-env-filetime
branch
from
c2ae062 to
718a918
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
07c391f to
004542d
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
004542d to
ac9ff7a
Compare
kitlangton
force-pushed
the
effectify-format
branch
2 times, most recently
from
9d70289 to
2f36dd1
Compare
Convert Format from Instance.state + namespace to Effect ServiceMap.Service. Bus subscription moves to layer constructor with addFinalizer cleanup. Legacy Format.init/status facades delegate via runPromiseInstance.
kitlangton
force-pushed
the
effectify-format
branch
from
2f36dd1 to
363bc0c
Compare
This was referenced Mar 16, 2026
4 tasks
ConanXu-math
pushed a commit
to ConanXu-math/opencode
that referenced
this pull request
Mar 17, 2026
3 tasks
AvatarGanymede
pushed a commit
to AvatarGanymede/opencode-dev
that referenced
this pull request
Mar 19, 2026
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 19, 2026
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 20, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instance.state+ namespace to EffectServiceMap.ServiceaddFinalizercleanup (no listener leak)Format.init/Format.statusfacades delegate viarunPromiseInstanceTest plan
bun run test test/format/format.test.ts— 4 tests passStack: effectify-watcher → effectify-file-watcher-service → effectify-vcs → effectify-env-filetime → effectify-format
Stack
effectify-format(open)dev(base)effectify-file(open)effectify-format-> refactor(file): effectify FileService as scoped service #17678effectify-file-> refactor(skill): effectify SkillService as scoped service #17810effectify-skill