Skip to content

fix(app): desktop app & Safari comments via button click#17520

Open
goszczynskip wants to merge 1 commit intoanomalyco:devfrom
goszczynskip:fix/desktop-app-comments-adding
Open

fix(app): desktop app & Safari comments via button click#17520
goszczynskip wants to merge 1 commit intoanomalyco:devfrom
goszczynskip:fix/desktop-app-comments-adding

Conversation

@goszczynskip
Copy link

Issue for this PR

Closes #11947

Type of change

  • Bug fix

What does this PR do?

This PR fixes the bug in desktop app and in Safari where adding comments to file view via button mouse click was impossible in OSX.

Issue was present because of Safari different handling of the shadow dom events propagation compared to other browsers.

Chain of (important) actions happening on submit button click in Safari:

  1. line comment textarea loses focus
  2. on:focusout event is being called
  3. annotation list is being updated
  4. UI updates (this is unique for Safari)
  5. Button click event is never triggered because button isn't longer a valid target.

How did you verify your code works?

I've run local version of Opencode desktop Tauri app in OSX. Verified that it's broken before fixes.
Also I've verified that the same happens in web view in Safari.

I've run following manual tests in lastest Chrome, Firefox and Safari:
I've tested that comments are added on button clicks.
I've tested that line comment popover isn't closed on clicks within popover.
I've tested that clicking on other lines closes line comment popover.

Screenshots / recordings

Screen.Recording.2026-03-14.at.20.53.07.mov

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@goszczynskip goszczynskip changed the title fix: desktop app comments adding fix: adding desktop app comments via button click is broken on Safari Mar 14, 2026
@goszczynskip goszczynskip changed the title fix: adding desktop app comments via button click is broken on Safari fix: desktop app & Safari comments via button click Mar 14, 2026
@goszczynskip goszczynskip changed the title fix: desktop app & Safari comments via button click fix(app): desktop app & Safari comments via button click Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop - Can't add comments on "all files" view

1 participant