Merged
Conversation
Use Effect.partition instead of Effect.forEach so that if any account's server is unreachable, the remaining accounts still return their orgs instead of failing the entire operation. Failed accounts are logged as warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orgsByAccount()usedEffect.forEachwhich fails entirely if any account's server is unreachableEffect.partitionso unreachable servers are skipped and remaining accounts still return their orgsFixes
oc orgsandoc switchcrashing when you have stale accounts pointing to servers that are down.Test plan
oc orgsstill shows orgs from working accounts