fix(preview): sanitize channel-derived versions for plugin installs#16222
Draft
anduimagui wants to merge 2 commits intoanomalyco:devfrom
Draft
fix(preview): sanitize channel-derived versions for plugin installs#16222anduimagui wants to merge 2 commits intoanomalyco:devfrom
anduimagui wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
8ca6602 to
d823cd7
Compare
d823cd7 to
b42cec4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16224
Type of change
What does this PR do?
This fixes preview version generation when the channel/branch name contains / (for example opencode/lucky-forest), which produced a non-semver prerelease label and broke plugin dependency installs in desktop dev/new workspace flows.
The patch sanitizes preview channel/version strings to semver-safe tokens and adds a pluginVersion guard in config install logic so invalid preview versions automatically fall back to *.
How did you verify your code works?
Screenshots / recordings
N/A (non-UI fix).
Checklist