fix(copilot): extend mini model exclusion to cover gpt-5.x-mini variants#15818
Open
Juhwa-Lee1023 wants to merge 3 commits intoanomalyco:devfrom
Open
fix(copilot): extend mini model exclusion to cover gpt-5.x-mini variants#15818Juhwa-Lee1023 wants to merge 3 commits intoanomalyco:devfrom
Juhwa-Lee1023 wants to merge 3 commits intoanomalyco:devfrom
Conversation
The shouldUseCopilotResponsesApi check previously excluded only models starting with 'gpt-5-mini', meaning future minor-versioned mini models like 'gpt-5.1-mini', 'gpt-5.2-mini' would be incorrectly routed to the Responses API instead of the Chat API. Broaden the exclusion to cover any model in the gpt-5 family that contains 'mini' in its name, matching the original intent of excluding all lightweight/mini variants from the Responses API.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15823
Type of change
What does this PR do?
shouldUseCopilotResponsesApiinpackages/opencode/src/provider/provider.tsexcluded only models whose ID starts withgpt-5-mini. This means minor-versioned mini models likegpt-5.1-miniorgpt-5.2-miniwere incorrectly routed to the Responses API instead of the Chat Completions API, since their IDs do not start withgpt-5-mini.The fix broadens the exclusion: any model in the
gpt-5family whose ID containsminiis now excluded from the Responses API. This matches the original intent from PR #5877 (exclude all lightweight/mini variants) while staying forward-compatible with OpenAI'smajor.minornaming convention.gpt-5-minigpt-5.1-minigpt-5.2-minigpt-5gpt-5.1How did you verify your code works?
Reviewed the existing
shouldUseCopilotResponsesApiunit tests inpackages/opencode/test/provider/provider.test.tsand confirmed all pass with the updated logic.Screenshots / recordings
N/A — logic-only change, no UI.
Checklist