fix(opencode): robust process exit detection for child processes#15757
Open
NachoFLizaur wants to merge 3 commits intoanomalyco:devfrom
Open
fix(opencode): robust process exit detection for child processes#15757NachoFLizaur wants to merge 3 commits intoanomalyco:devfrom
NachoFLizaur wants to merge 3 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
contributor
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my searches, I found one potentially related PR: Related PR Found:
All other search results only returned the current PR (#15757) itself. The searches did not find any open PRs that are direct duplicates of this process exit detection fix. PR #13186 is adjacent in addressing process-related issues but focuses on memory leaks and cleanup handlers rather than the specific exit detection problem. |
Contributor
Author
|
fixed description according to template |
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
NachoFLizaur
force-pushed
the
fix/bash-process-exit-detection
branch
from
f36ae38 to
9da397e
Compare
This was referenced Mar 3, 2026
…t-detection # Conflicts: # packages/opencode/src/shell/shell.ts
NachoFLizaur
force-pushed
the
fix/bash-process-exit-detection
branch
from
43f75bc to
e4b57cf
Compare
binarydoubling
added a commit
to binarydoubling/opencode
that referenced
this pull request
Mar 9, 2026
Port robust process exit detection from PR anomalyco#15757 to fix zombie/stuck child processes in containers where Bun fails to deliver exit events. - Add polling watchdog to bash tool and Process.spawn that detects process exit via kill(pid, 0) when event-loop events are missed - Add process registry (active map) with stale/reap exports for server-level watchdog to detect and clean up stuck bash processes - Improve Shell.killTree with alive() helper and proper SIGKILL escalation after SIGTERM timeout - Add session-level watchdog interval in prompt loop to periodically reap stale bash processes Based on the work in anomalyco#15757. Co-Authored-By: Nacho F. Lizaur <NachoFLizaur@users.noreply.github.com>
binarydoubling
added a commit
to binarydoubling/opencode
that referenced
this pull request
Mar 9, 2026
Complete the port of PR anomalyco#15757 with remaining pieces: - Add stdio end event redundancy as third fallback for exit detection (fires when pipe file descriptors close, independent of exit events) - Add diagnostic log.info calls at spawn, abort, timeout, and each exit detection path for debugging container issues - Add comprehensive tests: defensive patterns, polling watchdog isolation, Shell.killTree, server-level watchdog (stale/reap), stdio end events, and Process.spawn defensive patterns - Skip truncation tests on Windows (matching upstream) Co-Authored-By: Nacho F. Lizaur <NachoFLizaur@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #14769
Possible related issue that might get fixed by this: #15675 (it seems related based on the description)
Type of change
What does this PR do?
The bash tool and
Process.spawnrely solely on Bun'sproc.once("exit")to detect when a child process finishes. In containerized environments, this event is not reliably delivered (due to Bun), causing the completion promise to hang forever, tool calls get permanently stuck atstatus=running.The fix removes the runtime dependency on Bun for process exit detection, replacing it with a multi-layer strategy that uses OS-level primitives:
closeevent: independent signal path fromexitin Bun's internalsproc.exitCodeandprocess.kill(pid, 0)to detect dead processes via OS-level signals, completely bypassing Bun's event systemprompt.ts): external safety net that force-completes processes stuck past their timeoutAll detection paths funnel through a single
done()function guarded by aresolvedboolean, ensuring exactly-once Promise resolution.Also improves
Shell.killTree()with analive()check before escalating from SIGTERM to SIGKILL.How did you verify your code works?
Polling watchdog isolation tests directly prove exit detection works WITHOUT exit/close events firing (simulates the exact Bun failure mode).
Regression tests verify normal bash tool execution is unaffected by the additional detection layers. Shell.killTree tests verify SIGTERM->alive check->SIGKILL escalation.
I also tested it in containerized opencode serve mode, bash tool calls now complete reliably instead of hanging.
Screenshots / recordings
No UI changes.
Checklist