fix(desktop): restore shell path env for desktop sidecar#15211
Merged
Conversation
github-actions bot
pushed a commit
to chrn11/opencode
that referenced
this pull request
Feb 26, 2026
figloalds
pushed a commit
to figloalds/opencode
that referenced
this pull request
Feb 27, 2026
jonathanmiddleton
pushed a commit
to jonathanmiddleton/opencode
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15195
Type of change
What does this PR do?
Desktop sidecar spawn now loads shell environment safely before launch. It probes
SHELL -il -c "env -0"with a hard timeout, falls back to-lonly when needed, skips nushell probing, and merges the result with desktop-required env overrides.This restores PATH-dependent commands in Desktop while keeping protection against interactive shell hangs.
How did you verify your code works?
cargo test --libinpackages/desktop/src-tauri.Screenshots / recordings
N/A (non-UI desktop backend change)
Checklist