fix(opencode): prefer monorepo roots for jdtls#14049
Open
kurochenko wants to merge 2 commits intoanomalyco:devfrom
Open
fix(opencode): prefer monorepo roots for jdtls#14049kurochenko wants to merge 2 commits intoanomalyco:devfrom
kurochenko wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found a potentially related PR: PR #12123: "fix: Multiple jdtls LSPs eating memory in java monorepos" This PR appears to address the same core issue - preventing multiple JDTLS processes from being spawned in Java monorepos. The current PR (14049) seems to be a continuation or refinement of this work, implementing the specific root detection strategy to solve the issue (#11368) that was likely identified in or related to PR #12123. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settings.gradle(.kts)), then wrapper markers (gradlew), and only then nearest module build filessettings.gradle/build.gradle) and Kotlin DSL (*.kts) casesVerification
bun test test/lsp/server-root.test.tsbun test test/lsp/*.test.tsFixes #11368