fix: address 6 memory leaks for long-running sessions

[feelsodev]

Summary

Fixes 6 memory leaks that cause RSS to grow to multi-GB levels during long-running sessions.

Changes

1. queue.ts — AsyncQueue termination

   • Added close() and drain() methods with DONE sentinel symbol
   • [Symbol.asyncIterator] now breaks on close instead of looping forever
   • Prevents leaked promises and unbounded queue growth

2. bash.ts — Output buffer cap

   • Replaced output += chunk.toString() with Buffer[] ring buffer
   • 10 MB hard cap; oldest chunks evicted when exceeded
   • Eliminates O(n²) string concatenation and caps memory for long commands

3. lsp/client.ts — Diagnostics Map cleanup

   • diagnostics.clear() on shutdown()
   • LRU eviction when Map exceeds 5,000 entries (delete-before-set pattern)
   • Prevents unbounded Map growth in large workspaces

4. bus/index.ts — Subscription cleanup on dispose

   • subscriptions.clear() in dispose callback after notifying wildcard listeners
   • Prevents subscription array leak across instance lifecycle

5. pty/index.ts — Buffer chunking

   • Replaced buffer: string with bufferChunks: string[] + bufferLen tracker
   • Chunk-based eviction instead of string.slice() on every write
   • Reduces GC pressure from repeated large string allocations

6. index.ts — Shutdown resource cleanup

   • Added Instance.disposeAll() in finally block
   • Ensures all instance-scoped resources (LSP clients, bus, PTY sessions) are released on exit

Test plan

• bunx tsc --noEmit — zero type errors
• Full turbo typecheck across all 12 packages — all pass
• Manual: run opencode for extended session, verify RSS stays stable

Closes #10913

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential duplicate PRs found:

1. PR fix(opencode): resolve multiple memory leaks in long-running sessions #10914 - "fix(opencode): resolve multiple memory leaks in long-running sessions"

   • fix(opencode): resolve multiple memory leaks in long-running sessions #10914
   • Why related: Addresses the same issue of memory leaks in long-running sessions with similar scope

2. PR fix(memory): resolve 6 memory leak issues in long-running sessions #12053 - "fix(memory): resolve 6 memory leak issues in long-running sessions"

   • fix(memory): resolve 6 memory leak issues in long-running sessions #12053
   • Why related: Explicitly mentions fixing the same "6 memory leak issues" targeting long-running sessions - likely addresses identical problems

Please review PRs #10914 and #12053 to confirm if they overlap with the current PR #13594, particularly regarding the changes to queue.ts, bash.ts, lsp/client.ts, bus/index.ts, pty/index.ts, and the shutdown resource cleanup.

[TheAllSeeingPie]

The following comment was made by an LLM, it may be inaccurate:

Potential duplicate PRs found:

1. PR fix(opencode): resolve multiple memory leaks in long-running sessions #10914 - "fix(opencode): resolve multiple memory leaks in long-running sessions"

   • fix(opencode): resolve multiple memory leaks in long-running sessions #10914
   • Why related: Addresses the same issue of memory leaks in long-running sessions with similar scope

2. PR fix(memory): resolve 6 memory leak issues in long-running sessions #12053 - "fix(memory): resolve 6 memory leak issues in long-running sessions"

   • fix(memory): resolve 6 memory leak issues in long-running sessions #12053
   • Why related: Explicitly mentions fixing the same "6 memory leak issues" targeting long-running sessions - likely addresses identical problems

Please review PRs #10914 and #12053 to confirm if they overlap with the current PR #13594, particularly regarding the changes to queue.ts, bash.ts, lsp/client.ts, bus/index.ts, pty/index.ts, and the shutdown resource cleanup.

This would supersede #10914 and #12053 and bring significant stability to the Opencode platform and make it way more viable for power-users like myself who want to run multiple sessions for many hours.

[mohamedbouddi7777-dev]

Ok في الاثنين، ١٦ فبراير ٢٠٢٦، ٢١:٤٠ Joe Swan ***@***.***> كتب:

…

*TheAllSeeingPie* left a comment (anomalyco/opencode#13594) <#13594 (comment)> *The following comment was made by an LLM, it may be inaccurate:* *Potential duplicate PRs found:* 1. *PR #10914 <#10914>* - "fix(opencode): resolve multiple memory leaks in long-running sessions" - #10914 <#10914> - *Why related:* Addresses the same issue of memory leaks in long-running sessions with similar scope 2. *PR #12053 <#12053>* - "fix(memory): resolve 6 memory leak issues in long-running sessions" - #12053 <#12053> - *Why related:* Explicitly mentions fixing the same "6 memory leak issues" targeting long-running sessions - likely addresses identical problems Please review PRs #10914 <#10914> and #12053 <#12053> to confirm if they overlap with the current PR #13594 <#13594>, particularly regarding the changes to queue.ts, bash.ts, lsp/client.ts, bus/index.ts, pty/index.ts, and the shutdown resource cleanup. This would supersede #10914 <#10914> and #12053 <#12053> and bring significant stability to the Opencode platform and make it way more viable for power-users like myself who want to run multiple sessions for many hours. — Reply to this email directly, view it on GitHub <#13594 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/B2DFN3SRPYB46OQANEKET7D4MI2ONAVCNFSM6AAAAACVEECD72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMJQGYZDGMRYGU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>