Skip to content

fix: use absolute paths for sidebar session navigation #12898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamdotdevin merged 1 commit into from
Feb 10, 2026
Merged

fix: use absolute paths for sidebar session navigation #12898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/app/src/pages/layout/sidebar-items.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export const SessionItem = (props: SessionItemProps): JSX.Element => {

const item = (
<A
href={`${props.slug}/session/${props.session.id}`}
href={`/${props.slug}/session/${props.session.id}`}
class={`flex items-center justify-between gap-3 min-w-0 text-left w-full focus:outline-none transition-[padding] ${props.mobile ? "pr-7" : ""} group-hover/session:pr-7 group-focus-within/session:pr-7 group-active/session:pr-7 ${props.dense ? "py-0.5" : "py-1"}`}
Comment on lines +147 to 148
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SessionItem's main link was updated to an absolute path, but the onMessageSelect handler in the same component still calls navigate(${props.slug}/session/${props.session.id}) without a leading / (see ~line 234). That relative navigation can hit the same SolidJS router resolution issue and produce non-routable paths; update it to use an absolute path for consistency and correctness.

Copilot uses AI. Check for mistakes.
onPointerEnter={scheduleHoverPrefetch}
onPointerLeave={cancelHoverPrefetch}
Expand Down Expand Up @@ -285,7 +285,7 @@ export const NewSessionItem = (props: {
const tooltip = () => props.mobile || !props.sidebarExpanded()
const item = (
<A
href={`${props.slug}/session`}
href={`/${props.slug}/session`}
end
class={`flex items-center justify-between gap-3 min-w-0 text-left w-full focus:outline-none ${props.dense ? "py-0.5" : "py-1"}`}
onClick={() => {
Expand Down
Loading