feat: mcp-search tool for lazy loading mcp#12520
feat: mcp-search tool for lazy loading mcp#12520TheOutdoorProgrammer wants to merge 1 commit intoanomalyco:devfrom
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Potential Related PR Found: PR #8771 - "feat: add mcp_lazy mode for on-demand MCP tool loading" Why it's related: This is the original PR that the current PR #12520 is based on. According to the PR description, PR #12520 is a rebase of PR #8771 onto the head of dev. Both PRs address the same feature: implementing lazy loading for MCP tools with the Since PR #12520 is explicitly stated to be a rebase of PR #8771, you should verify whether #8771 is still open or if it should be closed in favor of #12520. |
0aea13e to
8ab6573
Compare
|
This feature is absolutely needed — lazy MCP loading is one of the most requested capabilities and critical for users with many MCP servers. Thanks for rebasing and keeping this alive. A few issues I noticed reviewing the diff: MCP result handling is duplicated, not shared This is the core issue. The MCP tool wrapping logic in MCP output fidelity loss in lazy A consequence of the duplication: the normal path preserves rich content — images become Plugin hook payload inconsistency Another consequence: the normal path passes Search only matches server names
Generated file churn The Minor: the |
8ab6573 to
79cc25b
Compare
|
Trying to keep the head of my fork synced so its easy to merge this. @thdxr @adamdotdevin @rekram1-node Is this something you guys would want to add? If its of use to you guys, Im happy to make sure its still updated properly. I just dont want to maintain updating it if its not. 😊 |
|
@rekram1-node / @thdxr would be really nice to have this, would be nice to save some on context as well as the cost when adding many MCPs.. |
79cc25b to
1f0176d
Compare
|
This is an absolutely critical feature, really looking forward to this being merged into main soon |
f8eed0a to
9fe3de1
Compare
|
+1 |
|
Any updates on this? We really need a feature like this. |
d2af48c to
a81c6a8
Compare
a81c6a8 to
9f84574
Compare
|
@rmk40 implemented your suggestions 👍 |
|
i was about to write a plugin for this, then i found this PR... would love to see this on core... |
|
@TheOutdoorProgrammer i can see some tests failing btw, any idea on them? @thdxr @adamdotdevin @rekram1-node is there anything that you are looking for in the support, i don't think it's right to keep people hanging either if there are no intentions to merge this PR at all. ( If it's due to sheer traffic or PRs on this repo that's understadable but it is becoming a bit hard to track what you guys are looking for and what you are not, would be good to have some visbility on them ) |
|
@manorit2001 Im not sure. Im happy to dive into the problems but I'd like to wait until I hear from the maintaining team if they want this feature or not (no is perfectly acceptable). Its becoming a bit of a chore maintaining this so it can merge cleanly. If the maintainers can just give me a thumbs up or a thumbs down I will continue to maintain this PR or not based on their feedback. |
|
ping @nexxeln ? Also @TheOutdoorProgrammer , can you maybe look into possibility of having a plugin for this instead if possible, would be very handy to integrate if it it's not going in the main repo |
|
@manorit2001 I've actually seen a few plugins in some of the related issues. |
|
discussing internally |
|
+1 |
|
+1 |
edit: This was originally a rebase only, but I've since added some changes. Im still keeping this branch up to do date but its no longer solely a rebase.
original description
rebased #8771 onto the head of dev.