Skip to content

fix(app): session popover primary button hover style and make primary button style clearer #10554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexyaroshuk wants to merge 9 commits into
base: dev
Choose a base branch
from
+15 −9
Open

fix(app): session popover primary button hover style and make primary button style clearer #10554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e1e356c
release: v1.1.45
Jan 30, 2026
00637c0
fix: rm ai sdk middleware that was preventing <think> blocks from bei…
rekram1-node Jan 30, 2026
37bb52f
fix(ui): session popover primary button hover style and make primary …
alexyaroshuk Jan 25, 2026
1aca4ac
Merge remote-tracking branch 'upstream/dev' into fix/primary-button-h…
alexyaroshuk Jan 31, 2026
efd0e4a
Resolve conflicts with upstream/dev
github-actions[bot] Feb 19, 2026
2f65e71
Merge remote-tracking branch 'upstream/dev' into fix/primary-button-h…
alexyaroshuk Feb 19, 2026
5544e69
Merge remote-tracking branch 'upstream/dev' into fix/primary-button-h…
alexyaroshuk Feb 20, 2026
2251ed3
Resolve conflicts with upstream/dev
github-actions[bot] Feb 22, 2026
55b9546
Merge remote-tracking branch 'upstream/dev' into fix/primary-button-h…
alexyaroshuk Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/app/src/components/session/session-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,17 +449,19 @@ export function SessionHeader() {
class="rounded-xl [&_[data-slot=popover-close-button]]:hidden"
triggerAs={Button}
triggerProps={{
variant: "ghost",
class:
"rounded-md h-[24px] px-3 border border-border-weak-base bg-surface-panel shadow-none data-[expanded]:bg-surface-base-active",
classList: {
"rounded-r-none": share.shareUrl() !== undefined,
"border-r-0": share.shareUrl() !== undefined,
},
variant: "secondary",
class: "rounded-sm w-[60px] h-[24px] hover:bg-surface-raised-base-hover",
classList: { "rounded-r-none": shareUrl() !== undefined },
style: { scale: 1 },
}}
trigger={<span class="text-12-regular">{language.t("session.share.action.share")}</span>}
>
<input
type="text"
autofocus
style="position:absolute; left:-10000px; width:1px; height:1px; opacity:0;"
aria-hidden="true"
/>
<div class="flex flex-col gap-2">
<Show
when={share.shareUrl()}
Expand Down
5 changes: 4 additions & 1 deletion packages/ui/src/components/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@
color: var(--icon-invert-base);
}

/* Clear, darker hover fill for primary button */
&:hover:not(:disabled) {
background-color: var(--icon-strong-hover);
/* Subtler darken on hover to avoid overly dark button */
background-color: color-mix(in oklab, var(--button-primary-base) 75%, black 25%);
transition: background-color 100ms ease;
}
&:focus:not(:disabled) {
background-color: var(--icon-strong-focus);
Expand Down
3 changes: 2 additions & 1 deletion packages/ui/src/components/icon-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
}

&:hover:not(:disabled) {
background-color: var(--icon-strong-hover);
/* Align hover color with primary button hover to keep consistency */
background-color: color-mix(in oklab, var(--button-primary-base) 75%, black 25%);
}
&:focus:not(:disabled) {
background-color: var(--icon-strong-focus);
Expand Down