refactor: extract shared Output utility for command streaming #10076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both bash.ts (BashTool) and prompt.ts (shell command execution) had duplicated logic for accumulating command output that caused O(n²) memory usage from repeated string concatenation. Extract a shared Output utility that: - Accumulates output in memory up to a threshold (50KB) - Streams to a temp file when threshold is exceeded - Provides preview for UI display while streaming - Handles cleanup on abort This prep commit deduplicates the streaming logic so both code paths benefit from the fix and future improvements only need to be made once. Assisted-by: OpenCode (Claude claude-sonnet-4-20250514)
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found Potential Related PR:PR #9693: "fix: Prevent O(n²) memory usage in command output" This PR appears to be closely related - it addresses the same O(n²) memory usage issue from string concatenation in command output handling that PR #10076 is refactoring into a shared utility. |
Author
|
Sorry this change incorrectly rolled in the O(N^2) work too, I didn't review closely enough before filing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Both bash.ts (BashTool) and prompt.ts (shell command execution) had duplicated logic for accumulating command output that caused O(n²) memory usage from repeated string concatenation.
Extract a shared Output utility that:
This prep commit deduplicates the streaming logic so both code paths benefit from the fix and future improvements only need to be made once.
Assisted-by: OpenCode (Claude claude-sonnet-4-20250514)
How did you verify your code works?
Ran unit tests (though some fail locally here on git main too), and some light interactive testing.