Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing code coverage in sdk/signing #3924

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

batconjurer
Copy link
Member

@batconjurer batconjurer commented Oct 16, 2024

Describe your changes

Increase code coverage in crats/core/signing.rs

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 96.81934% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.82%. Comparing base (81467ed) to head (82fdf76).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/signing.rs 97.31% 21 Missing ⚠️
crates/wallet/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3924      +/-   ##
==========================================
+ Coverage   73.25%   73.82%   +0.57%     
==========================================
  Files         341      341              
  Lines      105334   106114     +780     
==========================================
+ Hits        77158    78342    +1184     
+ Misses      28176    27772     -404     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic changed the title Increasing code coverage in core/signing Increasing code coverage in sdk/signing Oct 17, 2024
@@ -0,0 +1,2 @@
- Added tests in crates/core/signing.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added tests in crates/core/signing.rs
- Added tests in crates/sdk/signing.rs

(don't need to bother with changelogs for tests-only PRs though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants