-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tx_ibc wasm again #3275
tx_ibc wasm again #3275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3275 +/- ##
==========================================
+ Coverage 53.79% 53.85% +0.06%
==========================================
Files 314 314
Lines 105784 105661 -123
==========================================
+ Hits 56903 56906 +3
+ Misses 48881 48755 -126 ☔ View full report in Codecov by Sentry. |
hmm, it still requires floating-point support. It didn't work after #3209.
|
@@ -260,28 +260,6 @@ fn run_ledger_ibc_with_hermes() -> Result<()> { | |||
wait_for_packet_relay(&port_id_a, &channel_id_a, &test_a)?; | |||
check_balances_after_back(&port_id_b, &channel_id_b, &test_a, &test_b)?; | |||
|
|||
// Transfer a token and it will time out and refund |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removed test was duplicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, but I think we better investigate and remove the usage of the floats (we can do it as a follow-up). I had a look and some usage comes from tendermint-rs and its use serde_json
which should be easy to replace by serde_json_wasm
* yuji/tx-ibc-wasm: gas: remove unused ibc tx gas remove allowed_txs bench add changelog enable floating-point support tx_ibc wasm again
* origin/yuji/tx-ibc-wasm: gas: remove unused ibc tx gas remove allowed_txs bench add changelog enable floating-point support tx_ibc wasm again
Describe your changes
Closes #1831
Revert the workaround for the issue, which is by using the temporary host_env function for IBC.
It still requires floating-point support.
Indicate on which release or other PRs this topic is based on
v0.36.1
Checklist before merging to
draft