Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash pool #3084

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Slash pool #3084

wants to merge 5 commits into from

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Apr 15, 2024

Describe your changes

Closes #2984

Indicate on which release or other PRs this topic is based on

v0.33.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone brentstone force-pushed the brent/slash-pool branch 2 times, most recently from 1ac3597 to c3b6d68 Compare April 17, 2024 20:31
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 95.58824% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 59.46%. Comparing base (97ec5b4) to head (77bdded).
Report is 10 commits behind head on main.

Files Patch % Lines
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 95.41% 5 Missing ⚠️
crates/apps/src/lib/config/genesis/chain.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
+ Coverage   59.39%   59.46%   +0.06%     
==========================================
  Files         298      298              
  Lines       92771    92911     +140     
==========================================
+ Hits        55104    55252     +148     
+ Misses      37667    37659       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate whether we can bound total supply more tightly in the case of slashes
1 participant