Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ibc tx host fn to workaround M1/2 WASM compilation issue #1904

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Sep 19, 2023

Describe your changes

As a workaround for #1831, the IBC tx execution is added as a native host fn.

Indicate on which release or other PRs this topic is based on:

0.22.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic changed the title add ibc tx host to workaround M1/2 WASM compilation issue add ibc tx host fn to workaround M1/2 WASM compilation issue Sep 19, 2023
@tzemanovic tzemanovic marked this pull request as ready for review September 19, 2023 15:00
Copy link
Member

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my M1 Mac! Thank you!

@Fraccaman
Copy link
Member

should we add this to draft?

@brentstone
Copy link
Collaborator

should we add this to draft?

I'm in favor of it. This also was crucial for me to be able to run e2e tests again.

@sug0 sug0 mentioned this pull request Sep 22, 2023
@sug0
Copy link
Contributor

sug0 commented Sep 22, 2023

is #1872 still relevant after this merges?

Fraccaman added a commit that referenced this pull request Sep 25, 2023
* origin/tomas/ibc-host-fn-workaround:
  changelog: #1904
  add ibc tx host to workaround M1/2 WASM compilation issue
@tzemanovic
Copy link
Member Author

is #1872 still relevant after this merges?

I think so, we can switch it back to wasm at some point

@brentstone brentstone merged commit 8a87038 into main Sep 25, 2023
11 of 12 checks passed
@brentstone brentstone deleted the tomas/ibc-host-fn-workaround branch September 25, 2023 17:19
@yito88 yito88 mentioned this pull request Nov 11, 2023
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants