Skip to content

ci: align custom images with flake for actions#53

Merged
ano333333 merged 5 commits into
masterfrom
features/52
Apr 3, 2026
Merged

ci: align custom images with flake for actions#53
ano333333 merged 5 commits into
masterfrom
features/52

Conversation

@ano333333

@ano333333 ano333333 commented Apr 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • align custom workflow container images with flake.nix (Node 24)
  • add Google Cloud CLI to custom node image for gcloud/gsutil commands
  • keep terraform jobs on official environment (no Docker-in-Docker change)
  • temporarily set master-push trigger branch to features/52 for validation

Verification

  • built and pushed updated images to GHCR:
    • ghcr.io/ano333333/ongeki-score-fetch/node:24.04
    • ghcr.io/ano333333/ongeki-score-fetch/playwright:24.04

Summary by CodeRabbit

  • ドキュメント

    • 開発環境イメージ仕様(Node.js/パッケージ/パッケージ管理)を更新
  • その他の変更

    • Node.js を v22 → v24 にアップグレード
    • パッケージ管理を pnpm 10.10.0(Corepack経由)に統一
    • Google Cloud CLI を開発イメージに追加
    • Playwrightイメージの不要パッケージを削除
    • ワークフローのプッシュ対象ブランチに features/52 を追加

@coderabbitai

coderabbitai Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@ano333333 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 9 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 9 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8b9673fe-eaa4-40c6-9aed-f0a120c2c725

📥 Commits

Reviewing files that changed from the base of the PR and between ac41ae3 and 8120b1f.

📒 Files selected for processing (1)
  • .github/workflows/images/Dockerfile.playwright

Walkthrough

Node.jsをv22からv24へ更新し、Dockerイメージの依存を調整(google-cloud-cli追加、unzip削除、git/gnupg追加等)。両イメージでCorepack経由のpnpm@10.10.0を有効化。READMEのイメージ説明と GitHub Actions の push トリガーが更新された。

Changes

Cohort / File(s) Summary
Dockerfiles
.github/workflows/images/Dockerfile.node, .github/workflows/images/Dockerfile.playwright
Node.jsのセットアップをv24に更新。aptインストールに --no-install-recommends を適用。npm@latest のグローバル更新を削除し、corepack enable + corepack prepare pnpm@10.10.0 --activate を追加。Nodeイメージに gnupg/gitgoogle-cloud-cli を追加。Playwrightイメージで git を追加し unzip を削除。
ドキュメント
.github/workflows/README.md
README上のイメージ仕様を更新:Node.jsバージョンをv24に、Nodeイメージへgoogle-cloud-cli追加、Playwrightイメージからunzip削除、双方でpnpm 10.10.0(Corepack経由)を明記。
ワークフロー設定
.github/workflows/master-push.yaml
ワークフローの名前と push トリガーの対象ブランチを拡張(master に加えて features/52 をトリガーに追加)。

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • nix/devShellの環境整備 #50 — Nodeバージョン更新、pnpm導入、Google Cloud CLI追加など開発/ランタイム環境変更と整合する変更。

Poem

🐰 ころりん跳んだ、Dockerの庭で
Nodeは二十四、ぴょんと成長中
pnpmは十点一〇、みんなで揃えて
gcloudも仲間、雲へひとっ跳び ☁️
新しい朝に、コードがはずむ!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed プルリクエストのタイトルは、主な変更内容(カスタム Docker イメージを flake.nix に合わせて更新)を明確かつ簡潔に要約しており、変更セット全体の核となる意図を正確に反映しています。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch features/52

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/images/Dockerfile.node:
- Around line 13-17: The apt-get install invocation in the Dockerfile RUN block
(the curl/baseline node setup sequence that runs nodesource_setup.sh and then
apt-get install -y nodejs) should include --no-install-recommends to avoid
pulling recommended packages and reduce image size; update that apt-get install
command to apt-get install -y --no-install-recommends nodejs (and apply the same
change to the other apt-get install block mentioned for lines 20-26) and keep
the cleanup rm -rf /var/lib/apt/lists/* step as-is.
- Around line 20-23: The APT source entry in the RUN command uses an insecure
URL ("http://packages.cloud.google.com/apt"); update the echo in the RUN
instruction to use the HTTPS URL ("https://packages.cloud.google.com/apt") so
the Google Cloud CLI APT repository is fetched over TLS (modify the RUN echo
that writes to /etc/apt/sources.list.d/google-cloud-sdk.list and keep the
subsequent gpg dearmor step unchanged).

In @.github/workflows/images/Dockerfile.playwright:
- Around line 4-8: The Dockerfile RUN apt-get install lines currently install
packages with recommended extras; update those RUN commands (the apt-get install
invocation in the Dockerfile.playwright RUN block and the similar block at lines
11-15) to include the --no-install-recommends flag so only required packages are
installed, keeping apt-get update and the trailing rm -rf /var/lib/apt/lists/*
unchanged to reduce image size and surface area.

In @.github/workflows/master-push.yaml:
- Around line 3-6: 現在の workflow の on: push: branches: 設定が "features/52"
のみに固定されており master への push で CI が起動しません。on: push: branches の配列に "master"
を併記するよう修正し、既存の "features/52" を残して ["master", "features/52"]
のように並べる(あるいは必要な他ブランチを追加する)ことでマージ後の CI 実行を復帰させてください。
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 105e9793-9c3b-48bf-9f56-867151adfe78

📥 Commits

Reviewing files that changed from the base of the PR and between 2af7f82 and 310d6c1.

📒 Files selected for processing (4)
  • .github/workflows/README.md
  • .github/workflows/images/Dockerfile.node
  • .github/workflows/images/Dockerfile.playwright
  • .github/workflows/master-push.yaml

Comment thread .github/workflows/images/Dockerfile.node
Comment thread .github/workflows/images/Dockerfile.node Outdated
Comment thread .github/workflows/images/Dockerfile.playwright Outdated
Comment thread .github/workflows/master-push.yaml Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/images/Dockerfile.playwright:
- Line 49: Dockerfile の WORKDIR 指定に末尾スペースが入っているため引数解釈の差分を招く可能性があります;該当の WORKDIR
行(現在 "WORKDIR / " となっている箇所)から末尾の空白を削除して明示的に "WORKDIR /" に揃えてください。
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4580ea7d-e7fe-4a5e-a05e-47cd434e7017

📥 Commits

Reviewing files that changed from the base of the PR and between 310d6c1 and ac41ae3.

📒 Files selected for processing (3)
  • .github/workflows/images/Dockerfile.node
  • .github/workflows/images/Dockerfile.playwright
  • .github/workflows/master-push.yaml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/master-push.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/images/Dockerfile.node

Comment thread .github/workflows/images/Dockerfile.playwright Outdated
ano333333 and others added 2 commits April 3, 2026 02:58
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@ano333333 ano333333 merged commit ff02d1f into master Apr 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant