Add options parameter that replaces strict_kwonly #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Nov 3, 2021
anntzer
reviewed
Nov 3, 2021
anntzer
reviewed
Nov 3, 2021
anntzer
reviewed
Nov 3, 2021
anntzer
reviewed
Nov 3, 2021
anntzer
reviewed
Nov 4, 2021
|
As a side point, looks like a recent setuptools release broke CI. Let's see whether they fix this quickly, otherwise I'll have to fiddle with the CI config :/ |
|
I bumped the dependency to docutils>=0.12 to fix the build, but you'll need to rebase the PR. |
added 8 commits
November 5, 2021 15:26
…er-master # Conflicts: # lib/defopt.py
…lt, kwonly). Two spaces after dots.
…zing to options and not bothering to pass strict_kwonly down the chain anywhere else.
|
@anntzer Thanks for all the good suggestions. I've done them all. Please take a look. |
anntzer
reviewed
Nov 5, 2021
anntzer
reviewed
Nov 5, 2021
anntzer
reviewed
Nov 5, 2021
…) is .... 'all' turns all parameters into command-line flags; 'has_default' turns a parameter into a command-line flag if and only if it has a default value.")
Plain single quotes (') in the docs to specify strings
Typehint should be Literal['kwonly', 'all', 'has_default']; ditto for bind. (I think I like this order)
|
@anntzer I've made the changes you suggested. Please take a look. |
anntzer
reviewed
Nov 7, 2021
|
Just one typo, then good to go Do you want to take care of squashing your commits yourself or should I do it? |
|
@anntzer I have fixed the double space. I'd be grateful if you could squash the commits. |
|
Merged into master as bcca151. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strict_kwonly flag only affects parameters that have a default value - when set to False, parameters with default values are accepted as keyword arguments instead of postional arguments.
Deprecate strict_kwonly and replace by options="has_default" (i.e. strict_kwonly=False), ="kwonly" (strict_kwonly=True), "all" (all parameters accepted as keyword arguments)