Documentation fix: incorrect literature references #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For all I can tell, neither book (these are not papers, but entire books) describes this algorithm. In fact, I could not find k-medoids at all in the first book, which chapter? So the claim that the implementation would be based on these is clearly incorrect.
|
Hi @kno10 , Good catch, thank you for the finding, I will double check everything and update K-Medoids as well as the documentation. |
annoviko
added
Documentaion
|
The naive k-means-style k-medoids algorithm can be found a few times in literature; but it never was found to perform very well - it gets stuck in bad local optima too easily, and tends to find much worse solutions than PAM. This also seems to be supported by theoretical analysis (where k-means-style algorithm can be arbitrarily bad, while for swap-based algorithms approximation guarantees have been proven). |
annoviko
added a commit
that referenced
this pull request
Jun 18, 2020
annoviko
added a commit
that referenced
this pull request
Aug 27, 2020
|
The implementation of the algorithm is aligned with the following paper (details: #503): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all I can tell, neither book (these are not papers, but entire books) describes this algorithm. In fact, I could not find k-medoids at all in the first book, which chapter?
So the claim that the implementation would be based on these is clearly incorrect.