Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C/C++ pyclustering] Forbid to use cluster_data #577

Closed
3 tasks done
annoviko opened this issue Jan 30, 2020 · 0 comments
Closed
3 tasks done

[C/C++ pyclustering] Forbid to use cluster_data #577

annoviko opened this issue Jan 30, 2020 · 0 comments
Assignees
Labels
Proposal Tasks that have been proposed by users Refactoring Tasks related to code refactoring

Comments

@annoviko
Copy link
Owner

annoviko commented Jan 30, 2020

Introduction
Current interface may confuse because cluster_data might be used instead of concrete type (such as dbscan_data, fcm_data, etc.). As a result segmentation fault occurs. The cluster_data shouldn't be accepted by algorithms to avoid this situation, concrete implementation should be used instead. If there is no concrete implementation than alias must be created.

Description

  • Update algorithm interface in order to use concrete type of data instead of cluster_data.
  • Update unit-tests.
  • Look for possibilities to forbid allocation of cluster_data, for example, to make it pure abstract class with partial implementation.

Links
There is an issue that indicates problem of current interface: #576 .

@annoviko annoviko added Refactoring Tasks related to code refactoring Proposal Tasks that have been proposed by users labels Jan 30, 2020
@annoviko annoviko self-assigned this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal Tasks that have been proposed by users Refactoring Tasks related to code refactoring
Projects
None yet
Development

No branches or pull requests

1 participant