Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kmeans++ incorrect distance calculation when the return_index keyword argument is True #485

Closed
metinsuloglu opened this issue Jan 20, 2019 · 2 comments
Closed

Kmeans++ incorrect distance calculation when the return_index keyword argument is True #485

metinsuloglu opened this issue Jan 20, 2019 · 2 comments
Assignees
@annoviko
Labels
Bug Tasks related to found bugs

Comments

@metinsuloglu
Copy link

The __calculate_shortest_distances method in the Python class center_initializer.py assumes the "center" argument contains a list of coordinate points as vectors, however the initialize() method may send a list of indices. When the return_index argument is True, this leads to incorrect euclidean distance calculations.
@annoviko annoviko self-assigned this Jan 20, 2019
@annoviko annoviko added the Bug Tasks related to found bugs label Jan 20, 2019
@annoviko
Copy link
Owner

Hello, @metinsuloglu!
I have checked the code and I agree this is a bug. I will provide correction for the problem.

annoviko added a commit that referenced this issue Jan 20, 2019
@annoviko
#485: Kmeans++ incorrect distance calculation when the return_index k…
109b07c 
…eyword argument is True.
@annoviko
Copy link
Owner

The correction is available on 'master' branch. And will be available in release 0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annoviko annoviko

Labels
Bug Tasks related to found bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annoviko @metinsuloglu