Create diff for generator for multipart/form-data; if ClientModel adds a wrapper type for MultipartFormDataContent#2
Open
annelo-msft wants to merge 20 commits intoopenai-generate-multipartfrom
Conversation
annelo-msft
changed the base branch from
openai-generate-clean
to
openai-generate-multipart
annelo-msft
commented
Mar 18, 2024
…openai-generate-multipart2
…openai-generate-multipart2
…openai-generate-multipart2
…openai-generate-multipart2
…openai-generate-multipart2
annelo-msft
commented
Mar 26, 2024
| private static readonly char[] _boundaryValues = "0123456789=ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz".ToCharArray(); | ||
|
|
||
| internal async Task<(BinaryContent, string, RequestOptions)> ToMultipartContentAsync() | ||
| internal MultipartFormDataBinaryContent ToMultipartContent() |
Owner
Author
There was a problem hiding this comment.
This feels like a nice simplification to the generated code for MPFD in #1 🤞
Owner
Author
There was a problem hiding this comment.
annelo-msft
commented
Mar 26, 2024
|
|
||
| (BinaryContent content, string contentType, RequestOptions options) = await audio.ToMultipartContentAsync().ConfigureAwait(false); | ||
| ClientResult result = await CreateTranscriptionAsync(content, contentType, options).ConfigureAwait(false); | ||
| using MultipartFormDataBinaryContent content = audio.ToMultipartContent(); |
Owner
Author
There was a problem hiding this comment.
In this version, the content-creation is not async, and the call pattern is a bit simplified.
Owner
Author
There was a problem hiding this comment.
annelo-msft
pushed a commit
that referenced
this pull request
Apr 8, 2024
Merge pull request #2 from joseharriaga/Update-ClientModel OpenAI REST API snapshot: https://raw.githubusercontent.com/openai/openai-openapi/b648b7823135e6fa5148ac9a303c16fdad050da6/openapi.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.