Skip to content

batch, vector stores, and fine tuning LRO and subclient pattern updates#11

Merged
annelo-msft merged 22 commits intoannelo-msft:oai-polling-lrofrom
chschrae:oai-polling-lro
Sep 20, 2024
Merged

batch, vector stores, and fine tuning LRO and subclient pattern updates#11
annelo-msft merged 22 commits intoannelo-msft:oai-polling-lrofrom
chschrae:oai-polling-lro

Conversation

@chschrae
Copy link
Copy Markdown

@chschrae chschrae commented Sep 6, 2024

No description provided.

Comment thread .dotnet/src/Generated/BatchClient.cs Outdated
Comment thread .dotnet/src/Custom/VectorStores/VectorStoreClient.Protocol.cs Outdated
Comment thread .dotnet/src/Custom/VectorStores/VectorStoreClient.cs
Comment thread .dotnet/src/Custom/VectorStores/VectorStoreClient.Convenience.cs
Comment thread .dotnet/src/Custom/VectorStores/CreateVectorStoreOperation.Protocol.cs Outdated
Comment thread .dotnet/src/Custom/FineTuning/FineTuningClient.cs Outdated
Comment thread .dotnet/src/Custom/FineTuning/FineTuningClient.Protocol.cs Outdated
Comment thread .dotnet/src/Custom/Batch/CreateBatchOperation.Protocol.cs
Comment thread .dotnet.azure/src/Custom/VectorStores/AzureCreateVectorStoreOperation.cs Outdated
Copy link
Copy Markdown
Owner

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests for the Azure LRO types?

Comment thread .dotnet.azure/src/Custom/Batch/AzureBatchClient.Protocol.cs
chschrae added 6 commits September 11, 2024 11:18
…polling-lro

# Conflicts:
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/Batch/AzureBatchClient.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/Batch/AzureCreateBatchOperation.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureCreateJobOperation.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureFineTuningClient.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureAddFileToVectorStoreOperation.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureAddFileToVectorStoreOperation.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureCreateBatchFileJobOperation.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureCreateBatchFileJobOperation.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureCreateVectorStoreOperation.cs
#	.dotnet/src/Custom/Batch/BatchClient.cs
#	.dotnet/src/Custom/FineTuning/FineTuningClient.cs
#	.dotnet/src/Custom/VectorStores/VectorStoreClient.cs
#	.dotnet/src/Generated/FineTuningClient.cs
Comment thread .dotnet/src/Custom/Batch/BatchClient.Protocol.cs Outdated
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/BatchTests.cs
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs Outdated
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs Outdated
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs Outdated
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs Outdated
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs Outdated
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/VectorStoreTests.cs Outdated
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/VectorStoreTests.cs Outdated
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/VectorStoreTests.cs Outdated
Comment thread .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/VectorStoreTests.cs Outdated
chschrae and others added 5 commits September 17, 2024 16:43
Co-authored-by: Anne Thompson <21269347+annelo-msft@users.noreply.github.com>
…s.cs

Co-authored-by: Anne Thompson <21269347+annelo-msft@users.noreply.github.com>
…e-openai-in-typespec into oai-polling-lro

# Conflicts:
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Copy link
Copy Markdown
Owner

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge with a plan for a follow up PR to address ContinuationToken issues

@annelo-msft annelo-msft merged commit 317601a into annelo-msft:oai-polling-lro Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants