Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.03 SSR broken = window is not defined #89

Closed
luisatmaniak opened this issue Jun 7, 2018 · 2 comments
Closed

7.03 SSR broken = window is not defined #89

luisatmaniak opened this issue Jun 7, 2018 · 2 comments
Assignees
Labels

Comments

@luisatmaniak
Copy link

I'm submitting a ... (check one with "x")

[ x] Bug report => search github for a similar issue or PR before submitting
[ ] Feature request
[ ] Other, please describe

Tell about your platform

  • flatPickr version : 4.x.x
  • Vue.js version : 2.x.x
  • Browser name and version : Chrome|Firefox|Safari x.x.x
  • This package version : 7.0.3

Current behavior
Not SSR compatible since 7.0.3, webpack generates "})(window, function(WEBPACK_EXTERNAL_MODULE__0) {" on line 10 of vue-flatpickr-component/dist/vue-flatpickr.js, which throws an error server-side.

Expected behavior
No to throw an error during SSR.

Minimal reproduction of the problem with instructions
Import it from node, don't even need to use it.

@ankurk91
Copy link
Owner

ankurk91 commented Jun 8, 2018

webpack/webpack#6642
webpack/webpack#6677

@ankurk91
Copy link
Owner

ankurk91 commented Jun 8, 2018

Thanks for reporting.

Should be fixed in v7.0.4.
Feel free to report again if you found it broken.

@ankurk91 ankurk91 closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants