Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-change event not gets triggered after changing config dynamically #37

Closed
ankurk91 opened this issue Nov 2, 2017 · 0 comments
Closed
Assignees

Comments

@ankurk91
Copy link
Owner

ankurk91 commented Nov 2, 2017

The component emits an on-change event that mimics the onChange hook from flatpickr.

If we change the config after the component has been mounted; None of the methods in config retains.

This is because of Object.assign does not handle this. Looking for a cheap and fast solution to get around this.

// changing config dynamically from your components
this.$set(this.configs.basic, 'mode', 'range');

P.S: Will try to use lodash/cloneDeep and see if this can fix Object.assign behavior .
P.S: Submit a PR flatpickr/flatpickr#1152

@ankurk91 ankurk91 self-assigned this Nov 2, 2017
ankurk91 added a commit that referenced this issue Dec 25, 2017
ankurk91 added a commit that referenced this issue Dec 25, 2017
* Enable deep watch on config
* Fix #20, #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant