Skip to content

Refactor media sync handling#2647

Merged
dae merged 2 commits intomainfrom
media-sync
Sep 10, 2023
Merged

Refactor media sync handling#2647
dae merged 2 commits intomainfrom
media-sync

Conversation

@dae
Copy link
Copy Markdown
Member

@dae dae commented Sep 9, 2023

  • The media USN is now returned in sync/meta, which avoids an extra round-trip.
  • Media syncing is now automatically started by the syncing code at the end of a normal or full sync, which avoids it competing for bandwidth and resources, and avoids duplicate invalid login messages when the auth token is invalid.
  • Added a new media_sync_progress() method to both check if media is syncing, and get access to the latest progress.
  • Updated the sync log screen to only show the latest line, like AnkiMobile.
  • Show media sync errors in a pop-up, so they don't get missed. Use a non-modal pop-up to avoid potential conflicts with other modals.

- The media USN is now returned in sync/meta, which avoids an extra
round-trip.
- Media syncing is now automatically started by the syncing code at
the end of a normal or full sync, which avoids it competing for bandwidth
and resources, and avoids duplicate invalid login messages when the auth
token is invalid.
- Added a new media_sync_progress() method to both check if media is
syncing, and get access to the latest progress.
- Updated the sync log screen to only show the latest line, like AnkiMobile.
- Show media sync errors in a pop-up, so they don't get missed. Use a non-modal
pop-up to avoid potential conflicts with other modals.
@dae
Copy link
Copy Markdown
Member Author

dae commented Sep 9, 2023

@abdnh mind giving this a quick look-over?

(@RumovZ your feedback is always welcome too, just conscious of your free time recently)

@abdnh
Copy link
Copy Markdown
Collaborator

abdnh commented Sep 9, 2023

Looking good to me.

@dae
Copy link
Copy Markdown
Member Author

dae commented Sep 10, 2023

Thanks Abdo!

@dae dae merged commit bfef908 into main Sep 10, 2023
martinetd added a commit to martinetd/anki-sync-server-rs that referenced this pull request Sep 17, 2023
anki 23.09 will include a protocol change (see linked PR) so we need to
update the anki base commit and patch.

I've aligned the rusqlite dependency to fix rust build, and while I was
it aligned a few more where rust would be building an extra version of
the lib for anki.

Link: ankitects/anki#2647
martinetd added a commit to martinetd/anki-sync-server-rs that referenced this pull request Sep 24, 2023
anki 23.10 includes protocol changes (see linked PR, and others) so we
need to update the anki base commit and patch.

I've aligned the rusqlite dependency to fix rust build, and while I was
it aligned a few more where rust would be building an extra version of
the lib for anki.

Link: ankitects/anki#2647
@dae dae deleted the media-sync branch October 11, 2023 03:06
martinetd added a commit to martinetd/anki-sync-server-rs that referenced this pull request Nov 23, 2023
anki 23.10 includes protocol changes (see linked PR, and others) so we
need to update the anki base commit and patch.

I've aligned the rusqlite dependency to fix rust build, and while I was
it aligned a few more where rust would be building an extra version of
the lib for anki.

Link: ankitects/anki#2647
martinetd added a commit to martinetd/anki-sync-server-rs that referenced this pull request Nov 23, 2023
anki 23.10 includes protocol changes (see linked PR, and others) so we
need to update the anki base commit and patch.

I've aligned the rusqlite dependency to fix rust build, and while I was
it aligned a few more where rust would be building an extra version of
the lib for anki.

Link: ankitects/anki#2647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants