Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DeckPickerTest to kotlin #11857

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

lukstbit
Copy link
Member

Purpose / Description

Migrate DeckPickerTest.java to kotlin following the migration guide.

How Has This Been Tested?

Ran the tests.

Checklist

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A couple of imports were removed

AnkiDroid/src/test/java/com/ichi2/anki/DeckPickerTest.kt Outdated Show resolved Hide resolved
AnkiDroid/src/test/java/com/ichi2/anki/DeckPickerTest.kt Outdated Show resolved Hide resolved
AnkiDroid/src/test/java/com/ichi2/anki/DeckPickerTest.kt Outdated Show resolved Hide resolved
@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Jul 15, 2022
@lukstbit lukstbit force-pushed the km_DeckPickerTest_unit branch 2 times, most recently from 55fc127 to 8ff2767 Compare July 15, 2022 16:17
@lukstbit lukstbit removed the Needs Author Reply Waiting for a reply from the original author label Jul 15, 2022
@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Jul 16, 2022
@lukstbit lukstbit force-pushed the km_DeckPickerTest_unit branch from 8ff2767 to 345ae70 Compare July 17, 2022 03:43
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikehardy mikehardy merged commit 42c4d9f into ankidroid:main Jul 17, 2022
@github-actions github-actions bot added this to the 2.16 release milestone Jul 17, 2022
@github-actions github-actions bot removed Needs Second Approval Has one approval, one more approval to merge Needs Review labels Jul 17, 2022
@lukstbit lukstbit deleted the km_DeckPickerTest_unit branch July 18, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants