-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Add Developer options
category
#11508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, doesn't affect normal users, cleans things up for devs
and related strings
66b6cdb
to
276cbcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick, then looks good to go!
I'm testing this on my phone currently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and I like this
from advanced category
276cbcc
to
04921d8
Compare
Oh, and yes, I've tested on a release build too and it works fine |
emulator flake is ReactiveCircus/android-emulator-runner#192 - unrelated to PR, restarting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm on my phone, merge at will if CI is happy
Hi there @BrayanDSO! This is the OpenCollective Notice for PRs merged from 2022-06-01 through 2022-06-30 If you are interested in compensation for this work, the process with details is here: We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month Please note that GSoC contributions are okay for this process. Our philosophy is that our users have donated to AnkiDroid for all contributions. The only PRs that will not go through the OpenCollective process are ones directly related to am accepted GSoC project from a selected participant, since those receive a stipend from GSoC itself. Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding. Thanks! |
Purpose / Description
Move options exclusive to debug builds to its own category from the bottom of advanced category.
Approach
How Has This Been Tested?
Screen_Recording_20220601-195748_AnkiDroid.mp4
Checklist
Please, go through these checks before submitting the PR.
if
statements)