Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Add Developer options category #11508

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

BrayanDSO
Copy link
Member

Purpose / Description

Move options exclusive to debug builds to its own category from the bottom of advanced category.

Approach

  1. Create a XML layout with the previous debug options
  2. Extract the debug options from the advanced category to the new one

How Has This Been Tested?

Screen_Recording_20220601-195748_AnkiDroid.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, doesn't affect normal users, cleans things up for devs

@mikehardy mikehardy added the Needs Second Approval Has one approval, one more approval to merge label Jun 2, 2022
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, then looks good to go!

I'm testing this on my phone currently

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and I like this

@BrayanDSO
Copy link
Member Author

BrayanDSO commented Jun 2, 2022

Oh, and yes, I've tested on a release build too and it works fine

@mikehardy
Copy link
Member

emulator flake is ReactiveCircus/android-emulator-runner#192 - unrelated to PR, restarting

@mikehardy mikehardy requested a review from david-allison June 2, 2022 15:45
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm on my phone, merge at will if CI is happy

@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jun 2, 2022
@Arthur-Milchior Arthur-Milchior merged commit 6d1019e into ankidroid:main Jun 2, 2022
@Arthur-Milchior Arthur-Milchior removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jun 2, 2022
@github-actions github-actions bot added this to the 2.16 release milestone Jun 2, 2022
@BrayanDSO BrayanDSO deleted the pref-dev_options branch June 2, 2022 18:44
@github-actions
Copy link
Contributor

Hi there @BrayanDSO! This is the OpenCollective Notice for PRs merged from 2022-06-01 through 2022-06-30

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please note that GSoC contributions are okay for this process. Our philosophy is that our users have donated to AnkiDroid for all contributions. The only PRs that will not go through the OpenCollective process are ones directly related to am accepted GSoC project from a selected participant, since those receive a stipend from GSoC itself.

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants