Fix: Unable to locate element error #1065 #1126
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1126 +/- ##
===========================================
- Coverage 87.30% 87.20% -0.10%
===========================================
Files 85 85
Lines 4057 4057
Branches 237 237
===========================================
- Hits 3542 3538 -4
- Misses 445 448 +3
- Partials 70 71 +1
Continue to review full report at Codecov.
|
sanjibansg
changed the title
| @@ -73,11 +73,35 @@ def check_event_form_values(self, event): | |||
| :param event: Iterable consisting values for events. | |||
| """ | |||
| settings = self.settings | |||
| try: | |||
There was a problem hiding this comment.
Instead of having this method multiple times, can you make a separate method and call this method everywhere.
sanjibansg
changed the title
|
@satya7289 Changes made as per asked, Do have a look. |
| @@ -87,12 +105,17 @@ def check_job_form_values(self, job): | |||
| :param job: Iterable consisting values for job. | |||
| """ | |||
| settings = self.settings | |||
| self.driver.implicitly_wait(8) | |||
There was a problem hiding this comment.
Put implicit wait time as a variable(instead of hardcoded time value).
There was a problem hiding this comment.
Shall I make a single global time variable to do the work for all the implicit waits? @satya7289
There was a problem hiding this comment.
Yes, Also squash multiples commit to a single commit by following the commit message guildlines.
Closing this PR due to some problems, opened PR #1150 for solving the issue, do review that. |
Description
Added the necessary Selenium explicit and implicit waits for automating the process without Travis CI failing for not locating elements.
Fixes #1065
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
All the Travis CI Checks passed after updating the code file.
Checklist:
Code/Quality Assurance Only