-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YouTube API enabling steps in readme.md #117
Conversation
@Rahulm2310 and @keshakaneria please check is this the right way to create a PR. |
You can have a look at a sample template for description for PR here. You need to checkmark the checkboxes which are completed. |
Okay
…On Thu, 4 Mar 2021, 14:35 Kesha K. Kaneria, ***@***.***> wrote:
@Rahulm2310 <https://github.com/Rahulm2310> and @keshakaneria
<https://github.com/keshakaneria> please check is this the right way to
create a PR.
Thank you for your help.
You can have a look at a sample template for description for PR here
<https://github.com/anitab-org/.github/blob/main/.github/PULL_REQUEST_TEMPLATE.md>.
You need to checkmark the checkboxes which are completed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANSVRCHYSXIF7X2DMPC6PLDTB5EL3ANCNFSM4YRZZHXQ>
.
|
@s4-2 You can remove the irrelevant (unchecked) options from the PR description |
README.md
Outdated
|
||
**Steps** | ||
|
||
- You need a [Google Account](https://www.google.com/accounts/NewAccount) to access the Google API Console, request an API key, and register your application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s4-2 As these steps follow a certain order, this list should be a numbered list instead of bullet points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
README.md
Outdated
- Select a [client library](https://developers.google.com/youtube/v3/libraries) to simplify your API implementation. | ||
- Familiarize yourself with the core concepts of the JSON (JavaScript Object Notation) data format. JSON is a common, language-independent data format that provides a simple text representation of arbitrary data structures. For more information, see [json.org](http://json.org/). | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, no need for these newlines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put dots after numbers to get an enumerated list.
README.md
Outdated
- Visit the [Enabled APIs page](https://console.developers.google.com/apis/enabled). In the list of APIs, make sure the status is ON for the YouTube Data API v3 | ||
- If your application will use any API methods that require user authorization, read the [authentication](https://developers.google.com/youtube/v3/guides/authentication) guide to learn how to implement OAuth 2.0 authorization. | ||
- Select a [client library](https://developers.google.com/youtube/v3/libraries) to simplify your API implementation. | ||
- Familiarize yourself with the core concepts of the JSON (JavaScript Object Notation) data format. JSON is a common, language-independent data format that provides a simple text representation of arbitrary data structures. For more information, see [json.org](http://json.org/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the last three steps are not related to the youtube api enabling process and can be removed. We just need steps for enabling youtube api in google dev console.
@Rahulm2310 Is this relevant now? |
README.md
Outdated
1 You need a [Google Account](https://www.google.com/accounts/NewAccount) to access the Google API Console, request an API key, and register your application. | ||
|
||
2 Create a project in the [Google Developers Console](https://console.developers.google.com/) and [obtain authorization credentials](https://developers.google.com/youtube/registering_an_application) so your application can submit API requests. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on merging your first pull request! 🎉🎉🎉 We here at AnitaB.org are proud of you! |
Sorry for late response, Thank you @annabauza :) |
Documentation
Add instruction in Readme.md includes step for enabling YT API.
Fixes #90
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only