-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:improved github actions to use a matrix #1079
Conversation
Lint check failing. I know you haven't made any changes but can you still run black? |
@epicadk yup see this comment |
Codecov Report
@@ Coverage Diff @@
## develop #1079 +/- ##
===========================================
+ Coverage 92.71% 92.90% +0.18%
===========================================
Files 38 38
Lines 2019 2073 +54
===========================================
+ Hits 1872 1926 +54
Misses 147 147
|
@epicadk the tests are still running twice , should the changes be done here as the same file is being updated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 looks good.
@@ -20,12 +20,16 @@ jobs: | |||
build: | |||
needs: lint | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
python: [3.7, 3.9] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not possible to use latest
for a matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK it only accepts numerical values but giving a try with latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epicadk it isn't possible , will revert the changes
Ready to merge after one more review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @vj-codes 🎉
Thank you so much for working on this!
Description
Improved github actions to use a matrix
Fixes #1078
Type of Change:
Checklist:
Code/Quality Assurance Only