Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:improved github actions to use a matrix #1079

Merged
merged 5 commits into from
May 1, 2021

Conversation

vj-codes
Copy link
Member

Description

Improved github actions to use a matrix

Fixes #1078

Type of Change:

  • Code
  • Quality Assurance

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@epicadk
Copy link
Member

epicadk commented Apr 26, 2021

Lint check failing. I know you haven't made any changes but can you still run black?

@vj-codes
Copy link
Member Author

@epicadk yup see this comment
it's passing locally for me but actions is failing

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1079 (f865234) into develop (9571c86) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1079      +/-   ##
===========================================
+ Coverage    92.71%   92.90%   +0.18%     
===========================================
  Files           38       38              
  Lines         2019     2073      +54     
===========================================
+ Hits          1872     1926      +54     
  Misses         147      147              
Impacted Files Coverage Δ
app/database/models/user.py 98.57% <ø> (ø)
app/api/jwt_extension.py 100.00% <0.00%> (ø)
app/api/resources/task.py 100.00% <0.00%> (ø)
app/api/dao/task_comment.py 100.00% <0.00%> (ø)
app/api/resources/task_comment.py 100.00% <0.00%> (ø)
app/api/models/mentorship_relation.py 100.00% <0.00%> (ø)
app/api/dao/user.py 85.82% <0.00%> (+0.05%) ⬆️
app/api/dao/admin.py 96.00% <0.00%> (+0.08%) ⬆️
run.py 96.15% <0.00%> (+0.15%) ⬆️
app/api/resources/mentorship_relation.py 96.51% <0.00%> (+0.21%) ⬆️
... and 4 more

@vj-codes vj-codes added the Status: Needs Review PR needs an additional review or a maintainer's review. label Apr 26, 2021
@vj-codes
Copy link
Member Author

@epicadk the tests are still running twice , should the changes be done here as the same file is being updated?

epicadk
epicadk previously approved these changes Apr 27, 2021
Copy link
Member

@epicadk epicadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 looks good.

@@ -20,12 +20,16 @@ jobs:
build:
needs: lint
runs-on: ubuntu-latest
strategy:
matrix:
python: [3.7, 3.9]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible to use latest for a matrix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK it only accepts numerical values but giving a try with latest

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epicadk it isn't possible , will revert the changes

@epicadk epicadk requested a review from isabelcosta April 27, 2021 12:11
@epicadk
Copy link
Member

epicadk commented Apr 27, 2021

Ready to merge after one more review.

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @vj-codes 🎉
Thank you so much for working on this!

@isabelcosta isabelcosta merged commit ca4728a into anitab-org:develop May 1, 2021
@isabelcosta isabelcosta removed the Status: Needs Review PR needs an additional review or a maintainer's review. label May 1, 2021
RiddhiAthreya pushed a commit to RiddhiAthreya/mentorship-backend that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use python 3.9 in GitHub actions.
3 participants