Fix dispatcher when no plugins are given #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When any plugin is using the dispatcher for nested actions it should pass all plugins again to avoid that any plugin as subtask would be handled. Currently this means a lot of plugins are broken because they don't pass plugins to the dispatcher. To fix this, take all Plugin subclasses when no plugin is given (we should at least have the default plugins).
Add test to verify that a plugin can run dispatch to handle subtasks of external plugins.
kurtmckee
reviewed
Jul 28, 2023
| @@ -0,0 +1,17 @@ | |||
| """Test that a plugin can call dispatcher for subtasks. | |||
|
|
|||
| The plugin calls dispatch with his data. | |||
There was a problem hiding this comment.
Suggested change
| The plugin calls dispatch with his data. | |
| The plugin calls dispatch with its data. |
| @@ -18,7 +18,10 @@ def __init__( | |||
| ): | |||
| self._log = Messenger() | |||
| self._setup_context(base_directory, options) | |||
| plugins = plugins or [] | |||
| if plugins == None: | |||
There was a problem hiding this comment.
Please always use identity, not equality, comparisons with None:
Suggested change
| if plugins == None: | |
| if plugins is None: |
| @@ -18,7 +18,10 @@ def __init__( | |||
| ): | |||
| self._log = Messenger() | |||
| self._setup_context(base_directory, options) | |||
| plugins = plugins or [] | |||
| if plugins == None: | |||
| plugins = Plugin.__subclasses__() | |||
There was a problem hiding this comment.
This will circumvent the configuration option --disable-built-in-plugins. It will re-enable plugins that the user may have requested be disabled.
|
I've submitted #343 to address this, but I think that it will respect the As a side effect, #343 introduces a cached Dispatcher instance that plugins can begin leveraging -- they can simply access |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When any plugin is using the dispatcher for nested actions it should
pass all plugins again to avoid that any plugin as subtask would be
handled.
Currently this means a lot of plugins are broken because they don't pass
plugins to the dispatcher.
To fix this, take all Plugin subclasses when no plugin is given (we
should at least have the default plugins).