Skip to content

fix(desktop): preserve main window bounds - #1

Closed
anirudhsama wants to merge 120 commits into
mainfrom
t3code/preserve-macos-window-size
Closed

fix(desktop): preserve main window bounds#1
anirudhsama wants to merge 120 commits into
mainfrom
t3code/preserve-macos-window-size

Conversation

@anirudhsama

Copy link
Copy Markdown
Owner

What Changed

Persist the desktop main window position and size across launches. Move and resize updates are debounced, maximized windows save their normal bounds, and fullscreen bounds are ignored.

Saved bounds are restored only when the complete rectangle fits within a currently connected display. Otherwise the window falls back to the existing default bounds at (0, 0, 1100, 780).

Why

The desktop app currently constructs every window with fixed dimensions, resetting the preferred position and size after restarting.

Addresses pingdotgg#1829.

Verification

  • 49 focused desktop tests passed
  • vp run typecheck
  • vp check

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • No unrelated changes are included

anirudhsama and others added 30 commits July 10, 2026 14:06
Co-authored-by: Horus Lugo <horusgoul@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Ben Davis <45952064+bmdavis419@users.noreply.github.com>
Co-authored-by: Alex <me@pixp.cc>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
theduke and others added 8 commits July 20, 2026 08:51
)

Co-authored-by: Shoaib Ansari <shoaibansari@Shoaibs-Mac-mini.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#2093)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: root <root@localhost.localdomain>
Resolve the DesktopWindow test conflict by preserving both window-bounds persistence coverage and the newer fullscreen event coverage.

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Jul 20, 2026
juliusmarminge and others added 17 commits July 20, 2026 11:16
Co-authored-by: codex <codex@users.noreply.github.com>
Use BrowserWindow normal bounds during fullscreen persistence so an in-flight resize is not discarded on quit.

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
…tgg#4163)

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
…tarting an empty one (pingdotgg#3617)

Co-authored-by: codex <codex@users.noreply.github.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
- Save bounds on native maximize and unmaximize events
- Update coverage for maximized window persistence
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@anirudhsama

Copy link
Copy Markdown
Owner Author

Merged upstream in pingdotgg#3851.

@anirudhsama
anirudhsama deleted the t3code/preserve-macos-window-size branch July 23, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.