Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log metrics #274

Merged
merged 3 commits into from
Nov 21, 2023
Merged

log metrics #274

merged 3 commits into from
Nov 21, 2023

Conversation

berendsliedrecht
Copy link
Member

@berendsliedrecht berendsliedrecht commented Nov 21, 2023 •
edited
Loading

  • github metrics
  • Updated dependencies
  • Make sure we can log lists

@berendsliedrecht
added metrics
a938d3a 
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht
workflow for metrics
b9efed3 
Signed-off-by: Berend Sliedrecht <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Merging #274 (5fd23e8) into main (d32e822) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Additional details and impacted files
Files Coverage Δ
crates/cli/src/modules/oob.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/connection.rs 0.0% <0.0%> (ø)

@berendsliedrecht
fix where lists were not logged
5fd23e8 
Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht berendsliedrecht requested review from a team November 21, 2023 13:11
@berendsliedrecht berendsliedrecht merged commit d8c3760 into main Nov 21, 2023
7 of 9 checks passed
@berendsliedrecht berendsliedrecht deleted the log-metrics branch November 21, 2023 13:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tommylans Tommylans Tommylans approved these changes

@TimoGlastra TimoGlastra Awaiting requested review from TimoGlastra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berendsliedrecht @Tommylans