Skip to content

Commit

Permalink
fix: log without state (#268)
Browse files Browse the repository at this point in the history
  • Loading branch information
berendsliedrecht committed May 1, 2023
1 parent 1539479 commit f20bb83
Show file tree
Hide file tree
Showing 16 changed files with 81 additions and 45 deletions.
6 changes: 2 additions & 4 deletions crates/automations/src/automations/credential_offer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ impl CredentialOfferAutomation {
+ Send
+ Sync,
) -> Result<()> {
info!({ "message": "Starting automation CredentialOfferAutomation" });
info!({ "message": "Starting automation" });
trace!({
"connection_id": self.connection_id,
"attributes": self.attributes
Expand Down Expand Up @@ -74,9 +74,7 @@ impl CredentialOfferAutomation {

let credential_definition = create_credential_definition.execute(&agent).await?;

info!({
"message": "Offering the credential..."
});
info!({ "message": "Offering the credential..." });

let credential_offer_response = agent
.send_offer(CredentialOfferOptions {
Expand Down
4 changes: 2 additions & 2 deletions crates/cli/src/modules/automation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ pub async fn parse_automation_args(
info!({ "message": "Credential offer" });
println!();

info!({
log!({
"message":
format!(
"{} invitation with connection id {}.",
Expand All @@ -116,7 +116,7 @@ pub async fn parse_automation_args(
)
});
println!();
info!({"message": "Use this URL", "invitation_url": connection.invitation_url });
log!({"message": "Use this URL", "invitation_url": connection.invitation_url });
println!();
println!();
info!({
Expand Down
12 changes: 6 additions & 6 deletions crates/cli/src/modules/configuration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ pub fn parse_configuration_args(options: &ConfigurationOptions) -> Result<()> {
Box::<dyn std::error::Error>::from(error::Error::CannotReadConfigurationFile)
})?;
info!({ "coniguration_path": config_path });
info!({ "output": output });
log!({ "output": output });
Ok(())
}
ConfigurationSubcommands::Add {
Expand All @@ -90,7 +90,7 @@ pub fn parse_configuration_args(options: &ConfigurationOptions) -> Result<()> {
if *default {
let (environment, configuration) = Configuration::init(token.clone());
Configuration::add(environment, configuration)?;
info!({
log!({
"message": "Successfully added the default agent",
"configuration_path": config_path
});
Expand All @@ -107,7 +107,7 @@ pub fn parse_configuration_args(options: &ConfigurationOptions) -> Result<()> {
// TODO: this can only be aca-py or afj
agent: agent.clone(),
};
info!({
log!({
"message":
format!(
"Writing {}: {} to {}",
Expand All @@ -117,7 +117,7 @@ pub fn parse_configuration_args(options: &ConfigurationOptions) -> Result<()> {
)
});
Configuration::add(environment.clone(), env)?;
info!({
log!({
"message":
format!(
"Successfully Added agent {} at {}.",
Expand All @@ -130,7 +130,7 @@ pub fn parse_configuration_args(options: &ConfigurationOptions) -> Result<()> {
Ok(())
}
ConfigurationSubcommands::Remove { environment } => {
debug!({
log!({
"message":
format!(
"{} environment {} from the configuration",
Expand All @@ -139,7 +139,7 @@ pub fn parse_configuration_args(options: &ConfigurationOptions) -> Result<()> {
)
});
Configuration::remove(environment.clone())?;
info!({
log!({
"message":
format!(
"{} {} from the configuration",
Expand Down
13 changes: 6 additions & 7 deletions crates/cli/src/modules/connection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,13 @@ pub async fn parse_connection_args(
agent.create_invitation(options).await.map(|response| {
loader.stop();
info!({ "message": "Created invititation"});
info!({ "connection_id": response.id});
log!({ "connection_id": response.id});
if *qr {
info!({"message": "Scan this QR code to accept the invitation"});
print_qr_code(&response.invitation_url).unwrap();
} else {
info!({ "message": "Another agent can use this URL to accept your invitation"});
info!({ "invitation_url": &response.invitation_url});
}
info!({ "message": "Another agent can use this URL to accept your invitation"});
log!({ "invitation_url": &response.invitation_url});
copy!("{}", response.invitation_url);
})
}
Expand All @@ -136,7 +135,7 @@ pub async fn parse_connection_args(
.map(|connection| {
debug!({ "connection": connection });
info!({"message": "Fetched connection id"});
info!({ "connection_id": connection.id });
log!({ "connection_id": connection.id });
})
}
ConnectionSubcommands::List {
Expand All @@ -152,7 +151,7 @@ pub async fn parse_connection_args(
Some(i) => agent.get_by_id(i.clone()).await.map(|connection| {
loader.stop();
copy!("{}", pretty_stringify_obj(&connection));
info!({ "connection": connection });
log!({ "connection": connection });
}),
None => {
let options = ConnectionGetAllOptions {
Expand All @@ -171,7 +170,7 @@ pub async fn parse_connection_args(
agent.get_all(options).await.map(|connections| {
loader.stop();
copy!("{}", pretty_stringify_obj(&connections));
info!({ "connections": connections });
log!({ "connections": connections });
})
}
},
Expand Down
2 changes: 1 addition & 1 deletion crates/cli/src/modules/credential.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ pub async fn parse_credentials_args(
loader.stop();
debug!({ "credential": credential });
info!({ "message": "Successefully offered a credential" });
info!({ "credential_exchange_id": credential.credential_exchange_id });
log!({ "credential_exchange_id": credential.credential_exchange_id });
})
}
}
Expand Down
4 changes: 2 additions & 2 deletions crates/cli/src/modules/credential_definition.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ pub async fn parse_credential_definition_args(
loader.stop();
copy!("{}", cred_def.credential_definition_id);
info!({ "message": "Created credential definition" });
info!({ "credential_definition_id": cred_def.credential_definition_id });
log!({ "credential_definition_id": cred_def.credential_definition_id });
})
}
CredentialDefinitionSubcommands::List { id } => match id {
Expand All @@ -89,7 +89,7 @@ pub async fn parse_credential_definition_args(
});
debug!({ "credential_definition": cred_def });
copy!("{}", pretty_stringify_obj(&loggable));
info!({ "credential_definition": loggable });
log!({ "credential_definition": loggable });
}),

None => agent.get_all().await.map(|cred_defs| {
Expand Down
2 changes: 1 addition & 1 deletion crates/cli/src/modules/feature.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pub async fn parse_features_args(agent: impl FeatureModule + Send + Sync) -> Res
agent.discover_features().await.map(|features| {
loader.stop();
debug!({ "features": features });
info!({
log!({
"protocols": features.disclose.protocols
});
})
Expand Down
2 changes: 1 addition & 1 deletion crates/cli/src/modules/multitenancy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pub async fn parse_multitenancy_args(
match &options.commands {
MultitenancySubcommands::Create {} => agent.create().await.map(|response| {
loader.stop();
info!({ "response": response });
log!({ "response": response });
copy!("{}", response.wallet_id);
}),
MultitenancySubcommands::Remove { wallet_id } => {
Expand Down
5 changes: 3 additions & 2 deletions crates/cli/src/modules/proof.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ pub async fn parse_proof_args(
(
p.0.clone(),
p.1.clone(),
p.2.parse::<i32>()
p.2.parse()
.map_err(|_| Error::PredicateValueNonNumber(p.0.clone(), p.2.clone()))
.unwrap(),
)
Expand All @@ -74,7 +74,8 @@ pub async fn parse_proof_args(
.await
.map(|proof| {
debug!({ "proof": proof });
info!({ "message": "Successefully requested a proof", "presentation_exchange_id": &proof.presentation_exchange_id});
info!({ "message": "Successefully requested a proof"});
log!({ "presentation_exchange_id": &proof.presentation_exchange_id });
copy!("{}", &proof.presentation_exchange_id);
})?;
loader.stop();
Expand Down
6 changes: 3 additions & 3 deletions crates/cli/src/modules/schema.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,22 +70,22 @@ pub async fn parse_schema_args(
.attr_names
.into_iter()
.for_each(|name| info!({ "schema_name": name }));
info!({ "schema_id": schema.id});
log!({ "schema_id": schema.id});
copy!("{}", schema.id);
})
}
SchemaSubcommands::List { id } => match id {
Some(i) => agent.get_by_id(i.clone()).await.map(|schema| {
loader.stop();
info!({ "schema": schema });
log!({ "schema": schema });
copy!("{}", pretty_stringify_obj(&schema));
}),
None => agent.get_all().await.map(|schemas| {
loader.stop();
schemas
.schema_ids
.iter()
.for_each(|schema_id| info!({ "schema_id": schema_id }));
.for_each(|schema_id| log!({ "schema_id": schema_id }));
info!({ "message": "Successfully fetched schema IDs" });
}),
},
Expand Down
14 changes: 7 additions & 7 deletions crates/cli/src/modules/wallet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ pub async fn parse_wallet_args(
.map(|response: DidList| {
loader.stop();
info!({ "message": "Found the following DID information"});
info!({ "response": response });
log!({ "response": response });
copy!("{}", pretty_stringify_obj(&response));
})
}
Expand All @@ -142,37 +142,37 @@ pub async fn parse_wallet_args(
agent.create_local_did(options).await.map(|response| {
loader.stop();
info!({ "message": format!("Successfully created local DID: {:?}", response.did) });
info!({ "response": response });
log!({ "response": response });
copy!("{}", pretty_stringify_obj(&response));
})
}
WalletSubcommands::RotateKeyPair { did } => {
agent.rotate_keypair(did.clone()).await.map(|response| {
loader.stop();
info!({ "message": format!("Successfully rotated keypair for DID: {did}") });
info!({ "response": response });
log!({ "response": response });
copy!("{}", pretty_stringify_obj(response));
})
}
WalletSubcommands::FetchPublicDid {} => agent.fetch_public_did().await.map(|response| {
loader.stop();
info!({ "message": "Wallet public DID" });
info!({ "response": response });
log!({ "response": response });
copy!("{}", pretty_stringify_obj(&response));
}),
WalletSubcommands::AssignPublicDid { did } => {
agent.assign_public_did(did.clone()).await.map(|response| {
loader.stop();
info!({ "message": "Successfully assigned public DID" });
info!({ "response": response });
log!({ "response": response });
copy!("{}", pretty_stringify_obj(&response));
})
}
WalletSubcommands::FetchDidEndpoint { did } => {
agent.fetch_did_endpoint(did.clone()).await.map(|response| {
loader.stop();
info!({ "message": format!("DID endpoint for DID: {did}") });
info!({ "response": response });
log!({ "response": response });
copy!("{}", pretty_stringify_obj(&response));
})
}
Expand All @@ -189,7 +189,7 @@ pub async fn parse_wallet_args(
agent.set_did_endpoint(options).await.map(|response| {
loader.stop();
info!({ "message": format!("Set DID endpoint for DID: {did}") });
info!({ "response": response });
log!({ "response": response });
copy!("{}", pretty_stringify_obj(response));
})
}
Expand Down
2 changes: 1 addition & 1 deletion crates/cli/src/modules/webhook.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ pub async fn parse_webhook_args(agent: impl WebhookModule + Send + Sync) -> Resu
)
},
);
info!({ "webhook_message": incoming_webhook_message, "event": event});
log!({ "webhook_message": incoming_webhook_message, "event": event});
})
.await
}
3 changes: 2 additions & 1 deletion crates/cli/src/register.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ pub async fn register() -> Result<()> {
LogLevel::Off
} else {
match cli.verbose {
1 => LogLevel::Info,
2 => LogLevel::Debug,
3.. => LogLevel::Trace,
_ => LogLevel::Info,
_ => LogLevel::default(),
}
};

Expand Down
7 changes: 6 additions & 1 deletion crates/logger/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//! Only cli bindings for now

use cli_clipboard::{ClipboardContext, ClipboardProvider};
use colored::Colorize;
use colored::{ColoredString, Colorize};
use serde::Serialize;
use std::sync::RwLock;

Expand All @@ -27,6 +27,9 @@ pub enum LogLevel {
/// Log warnings and above
Warn,

/// zero state
None,

/// Log info and above
#[default]
Info,
Expand All @@ -49,6 +52,7 @@ impl LogLevel {
Self::Debug => "debug".bold().blue(),
Self::Trace => "trace".bold().purple(),
Self::Off => "off".green(),
Self::None => ColoredString::default(),
};
s.to_string()
}
Expand All @@ -63,6 +67,7 @@ impl LogLevel {
Self::Debug => "debug",
Self::Trace => "trace",
Self::Off => "off",
Self::None => "",
};
s.to_string()
}
Expand Down
Loading

0 comments on commit f20bb83

Please sign in to comment.