feat: typography and optional pid #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah the onboarding became quite complex sadly. How do you want to show it within the app on main screen, as a modal? Or a push screen? Would be nice if we can reuse the complete flow, as otherwise we'll have consistencies very quickly 😬 |
TimoGlastra
approved these changes
Sep 12, 2024
|
It's quite some steps so I was thinking just a regular screen flow. I want to re-use most of it but there might be some differences. E.g. if you do it after the onboarding there is an extra screen needed for your wallet pin, as you can not re-use the value that the user has entered during the onboarding. But will do my best 👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've restructured the typography so that it's more consistent. I've also made the PID optional during the onboarding. For now, it's disabled on the main screen and if you want to set it up you'll need to reset. I'm working on extracting the scanning logic out of the onboarding but that was a bit more work than i thought 🥲.
For now this removes the PID req so we can test easier with just regular EAA's.
Screen.Recording.2024-09-12.at.14.59.42.mov