add readme #9
Merged
add readme #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilias Elbarnoussi <[email protected]>
IliasElbarnoussi
requested review from
Tommylans,
TimoGlastra and
berendsliedrecht
TimoGlastra
reviewed
Jun 10, 2024
README.md
Outdated
Comment on lines
2
to
8
| <picture> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://res.cloudinary.com/animo-solutions/image/upload/v1656578320/animo-logo-light-no-text_ok9auy.svg"> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://res.cloudinary.com/animo-solutions/image/upload/v1656578320/animo-logo-dark-no-text_fqqdq9.svg"> | ||
| <img alt="Animo Logo" height="250px" /> | ||
| </picture> | ||
| </p> | ||
|
|
There was a problem hiding this comment.
Should be paradym branding (e.g. from https://github.com/animo/paradym-wallet)
There was a problem hiding this comment.
Do we want to create a separate github organization for Paradym?
Comment on lines
+17
to
+19
| <a href="https://opensource.org/licenses/Apache-2.0"> | ||
| <img src="https://img.shields.io/badge/License-Apache_2.0-yellowgreen.svg" alt="Apache 2.0 License" /> | ||
| </a> |
There was a problem hiding this comment.
It's not open source, will we make the SDK open source? If not we sohuld remove this probably
There was a problem hiding this comment.
WE should probably add this to docs.paradym.id?
There was a problem hiding this comment.
I would assume that the endgoal of this would be to open source the library. It does not really change that as much the built code is almost the same as the source, right?
TimoGlastra
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilias Elbarnoussi [email protected]