-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add client with services #4
Merged
berendsliedrecht
merged 14 commits into
animo:main
from
IliasElbarnoussi:add-client-and-services
Jun 4, 2024
Merged
feat: add client with services #4
berendsliedrecht
merged 14 commits into
animo:main
from
IliasElbarnoussi:add-client-and-services
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
IliasElbarnoussi
commented
May 31, 2024
- feat: implement isHmacValid function to verify HMAC signatures
- hmac validation with nobles/hashes
- Update package.json
- add biomejs and pnpm
- change license in package.json & add license in root
- add client with the bundled services
Signed-off-by: Ilias Elbarnoussi <[email protected]>
Co-authored-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Ilias Elbarnoussi <[email protected]>
Signed-off-by: Ilias Elbarnoussi <[email protected]>
Signed-off-by: Ilias Elbarnoussi <[email protected]>
berendsliedrecht
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor points required before merging! Otherwise looks good!
Signed-off-by: Ilias Elbarnoussi <[email protected]>
Signed-off-by: Ilias Elbarnoussi <[email protected]>
berendsliedrecht
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small note about the generated code.
Signed-off-by: Ilias Elbarnoussi <[email protected]>
…arnoussi/paradym-api-test into add-client-and-services
Signed-off-by: Ilias Elbarnoussi <[email protected]>
berendsliedrecht
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.