bump package.json version to 0.0.1-0 #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilias Elbarnoussi <[email protected]>
IliasElbarnoussi
requested review from
berendsliedrecht,
Tommylans and
TimoGlastra
|
Do we want 1.0.0? |
|
I'm currently in the alpha release phase to ensure everything is functioning correctly before the major release. The version in package.json wasn't updated by release-it, likely because the release workflow published the version to npm but failed afterward. This probably prevented the version from being bumped to alpha: |
|
I think how the release is configured is that it doesn't update package.json but looks at the latest release on GitHub or NPM. E.g. see https://github.com/animo/react-native-ble-didcomm/blob/main/package.json |
|
Not sure why it closed?! |
|
You are right. I created the 0.0.1-0 release, so this issue can be closed. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilias Elbarnoussi [email protected]