add didcomm, dids, issuance, revocation & anoncred services to client #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilias Elbarnoussi <[email protected]>
Signed-off-by: Ilias Elbarnoussi <[email protected]>
TimoGlastra
requested changes
Jun 11, 2024
src/client.ts
Outdated
Comment on lines
26
to
32
| sdJwtVc: { | ||
| credentials: typeof SdJwtVcCredentialTemplatesService | ||
| presentations: typeof PresentationTemplatesService | ||
| } | ||
| anoncreds: { | ||
| credentials: typeof AnoncredsCredentialTemplatesService | ||
| } |
There was a problem hiding this comment.
Suggested change
| sdJwtVc: { | |
| credentials: typeof SdJwtVcCredentialTemplatesService | |
| presentations: typeof PresentationTemplatesService | |
| } | |
| anoncreds: { | |
| credentials: typeof AnoncredsCredentialTemplatesService | |
| } | |
| presentations: typeof PresentationTemplatesService, | |
| credentials: { | |
| sdJwtVc: typeof SdJwtVcCredentialTemplatesService, | |
| anoncreds: typeof AnoncredsCredentialTemplatesService | |
| } |
Co-authored-by: Timo Glastra <[email protected]>
TimoGlastra
requested changes
Jun 12, 2024
src/client.ts
Outdated
Comment on lines
26
to
32
| sdJwtVc: { | ||
| credentials: typeof SdJwtVcCredentialTemplatesService | ||
| presentations: typeof PresentationTemplatesService | ||
| } | ||
| anoncreds: { | ||
| credentials: typeof AnoncredsCredentialTemplatesService | ||
| } |
There was a problem hiding this comment.
It's still not correct. See my suggestion from previous review
TimoGlastra
approved these changes
Jun 12, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dids, issuance, revocation, anoncred services to client,Signed-off-by: Ilias Elbarnoussi [email protected]