[WIP] Support mruby 1.4.1 #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlga
commented
Oct 21, 2018
| @@ -126,8 +126,10 @@ void mrb_ext_set_instance_tt(struct RClass* class, enum mrb_vtype type) { | |||
| MRB_SET_INSTANCE_TT(class, type); | |||
| } | |||
|
|
|||
| int mrb_ext_ary_len(struct mrb_state* mrb, mrb_value array) { | |||
| return mrb_ary_len(mrb, array); | |||
| long long mrb_ext_ary_len(struct mrb_state* mrb, mrb_value array) { | |||
There was a problem hiding this comment.
This function has been dropped in favour of RARRAY_LEN
mlga
commented
Oct 21, 2018
| @@ -35,6 +36,9 @@ mkdir -p mruby-out/src/mrbgems | |||
|
|
|||
| cd mruby-$VERSION | |||
|
|
|||
| # Use only supported gems. | |||
| cat $DIR/mrusty.gembox > mrbgems/default.gembox | |||
There was a problem hiding this comment.
Needed for minirake not to create _init / _final functions for mruby-io and mruby-bin*.
mlga
commented
Oct 21, 2018
| # Copies all gems. | ||
|
|
||
| cp -R mrbgems/* ../mruby-out/src/mrbgems | ||
| cp -R build/host/mrbgems/* ../mruby-out/src/mrbgems | ||
|
|
||
| # String needs additional mruby header. | ||
|
|
||
| sed -i -e $'s/#include "common.h"/#include "mruby.h"\\\n#include "common.h"/g' include/mruby/string.h |
There was a problem hiding this comment.
Strange thing, string.h causes dozen undefined type errors without it.
mlga
commented
Oct 21, 2018
|
|
||
| # Copies header files so they will be available in top level includes. | ||
|
|
||
| find include/mruby -type f -name '*.h' -exec cp {} ../mruby-out/include \; |
There was a problem hiding this comment.
mruby-pack has includes in form of header.h instead of mruby/header.h.
mlga
commented
Oct 21, 2018
| # Copies ext header files required by gems. | ||
|
|
||
| mkdir -p ../mruby-out/include/mruby/ext | ||
| find mrbgems -path '*/ext/*' -name '*.h' -exec cp {} ../mruby-out/include/mruby/ext \; |
mlga
commented
Oct 21, 2018
| @@ -0,0 +1,88 @@ | |||
| MRuby::GemBox.new do |conf| | |||
| # Use standard IO/File class | |||
| # conf.gem :core => "mruby-io" | |||
|
Rust crates one binary that runs all the tests. I would suggest isolating this to one specific test first so that you know exactly where the segmentation fault is caused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to issue: #98 I've also wanted to upgrade to mruby 1.4.1. Applying few hacks (I just wanted to make it run first, then think about doing things properly).
I managed to make mrusty compile but
cargo testfails@dragostis I know you don't want to spent much time maintaining mrusty anymore but perhaps you can help me with some advice? I don't have much experience with Rust and even less with Ruby.