Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading resolve-url-loader with latest version #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Amitesh
Copy link

@Amitesh Amitesh commented Dec 26, 2016

Upgraded the resolve-url-loader with latest version because there was issue while creating sourceMap.
Error like:

WARNING in .//css-loader?minimize&sourceMap!(webpack)-angularity-solution//resolve-url-loader?sourceMap!./~/sass-loader?sourceMap!./components/num-pad/index.scss
resolve-url-loader cannot operate: source-map error
ENOENT: no such file or directory, scandir '/Users/amitesh/ahome/mm/projects/rainingforest/app-build'

Upgraded the resolve-url-loader with latest version because there was issue while creating sourceMap.
Error like:

WARNING in ./~/css-loader?minimize&sourceMap!(webpack)-angularity-solution/~/resolve-url-loader?sourceMap!./~/sass-loader?sourceMap!./components/num-pad/index.scss
      resolve-url-loader cannot operate: source-map error
      ENOENT: no such file or directory, scandir '/Users/amitesh/ahome/mathletics/projects/rainforestgames/app-build'
@bholloway
Copy link
Member

@Amitesh I am confident this change will not break anything - The release of [email protected] fixed problems with [email protected] and is backward compatible with earlier sass-loader.

However you would need to consult with @impaler regarding versioning and releasing webpack-angularity-solution. I suggest a minor version bump to be safe.

I will assign him and we will see what he says.

@Amitesh
Copy link
Author

Amitesh commented Dec 27, 2016

Hi @bholloway ,
Yes. I have tested this change with my current project and it looks good. Thanks again for solving the resolve issue in [email protected] release.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants