Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the vulnerabiltiy issue discussed in #499 #500

Open
wants to merge 3 commits into
base: legacy
Choose a base branch
from

Conversation

paimon0715
Copy link

@paimon0715 paimon0715 commented Jul 10, 2021

Fix the vulnerabiltiy issues discussed in #499.

Ugrade adm-zip ^0.4.9 ➔ ^0.5.2, since [email protected](>=0.5.2) has fixed the vulnerability SNYK-JS-ADMZIP-1065796.

@google-cla
Copy link

google-cla bot commented Jul 10, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 10, 2021
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@paimon0715
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jul 10, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@paimon0715
Copy link
Author

@StanislavKharchenko
It would be better if webdriver-manager can fix this issue in versions 12.1.* , 12.0.* , 10.3.*, and release them to npm. Then this vulnerbility patch can be automatically propagated into a large amount of downstream projects :)
Please check it.
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants