chore(logging): Adds a more clear error output for invalid drivers. #393

(#394)
angular · Jul 31, 2019 · b6e6613 · b6e6613
1 parent 579a05b
commit b6e6613
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/lib/binaries/chrome_xml.ts b/lib/binaries/chrome_xml.ts
@@ -108,7 +108,9 @@ export class ChromeXml extends XmlConfigSource {
   private getSpecificChromeDriverVersion(inputVersion: string): Promise<BinaryUrl> {
     return this.getVersionList().then(list => {
       const specificVersion = getValidSemver(inputVersion);
-
+      if (specificVersion === "") {
+        throw new Error(`version ${inputVersion} ChromeDriver does not exist`)
+      }
       let itemFound = '';
       for (let item of list) {
         // Get a semantic version.

diff --git a/lib/cmds/update.ts b/lib/cmds/update.ts
@@ -247,7 +247,11 @@ function unzip<T extends Binary>(binary: T, outputDir: string, fileName: string)
   // unzip the file
   logger.info(binary.name + ': unzipping ' + fileName);
   if (fileName.slice(-4) == '.zip') {
-    let zip = new AdmZip(path.resolve(outputDir, fileName));
+    try {
+      let zip = new AdmZip(path.resolve(outputDir, fileName));
+    } catch (e) {
+      throw new Error(`Invalid filename: ${path.resolve(outputDir, fileName)}`)
+    }
     zip.extractAllTo(outputDir, true);
   } else {
     // We will only ever get .tar files on linux

diff --git a/lib/files/downloader.ts b/lib/files/downloader.ts
@@ -103,7 +103,7 @@ export class Downloader {
              });
            })
         .catch(error => {
-          logger.error((error as any).msg);
+          logger.error((error as any).msg || (error as any).message);
         });
   }
 }