Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension fails to load in vscoder insider (debug mode) #449

Closed
ferozsho opened this issue Nov 23, 2019 · 6 comments · Fixed by #456
Closed

extension fails to load in vscoder insider (debug mode) #449

ferozsho opened this issue Nov 23, 2019 · 6 comments · Fixed by #456

Comments

@ferozsho
Copy link

Issue Type: Bug

The Angular Language Service server crashed 5 times in the last 3 minutes. The server will not be restarted.

Extension version: 0.802.3
VS Code version: Code - Insiders 1.41.0-insider (a747d264d668a947eeacd3492b60df6ce8dee6b4, 2019-11-23T11:09:42.834Z)
OS version: Windows_NT x64 10.0.17763

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz (8 x 3400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 23.95GB (17.72GB free)
Process Argv
Screen Reader no
VM 0%
@andrius-pra
Copy link
Collaborator

output logs:

Debugger listening on ws://127.0.0.1:6009/203b1305-2797-46a8-8c82-a98b7f2e1e41
For help, see: https://nodejs.org/en/docs/inspector
internal/modules/cjs/loader.js:630
    throw err;
    ^

Error: Cannot find module 'c:\Users\Andrius\.vscode-insiders\extensions\angular.ng-template-0.802.3\server\out\server.js'
    at Function._resolveFilename (internal/modules/cjs/loader.js:627:15)
    at Function._load (internal/modules/cjs/loader.js:531:27)
    at Function.runMain (internal/modules/cjs/loader.js:850:10)
    at internal/main/run_main_module.js:17:11 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
[Error - 16:18:29] Connection to server got closed. Server will not be restarted.

VSCode insider tries to load the extension in debug mode. The debug mode uses non-existing path for server module.

@kyliau kyliau changed the title Angular Language Service extension fails to load in vscoder insider (debug mode) Nov 23, 2019
@juristr
Copy link

juristr commented Nov 25, 2019

Can confirm. Just installed rc.3 on inside version and I'm getting the same issue

//update: I just found out that it also happens with the 0.802.3 version, so it might really be related to VSCode Insiders?

@andrius-pra
Copy link
Collaborator

I think it's caused by microsoft/vscode#85417. This pull request added inspect-port=0 to process arguments and this change will force to run all extensions in debug mode because of arguments will match DEBUG_FLAGS_PATTERN pattern.

@PowerMogli
Copy link

I think it's caused by microsoft/vscode#85417. This pull request added inspect-port=0 to process arguments and this change will force to run all extensions in debug mode because of arguments will match DEBUG_FLAGS_PATTERN pattern.

Any idea what we can do?

@andrius-pra
Copy link
Collaborator

Any idea what we can do?

Update to latest version. This issue (microsoft/vscode#85490) is already fixed.

kyliau pushed a commit to kyliau/vscode-ng-language-service that referenced this issue Nov 25, 2019
VS Code Insider launches extension in debug mode by defaul, but users
install prod bundle so we have to check whether dev bundle exists, and
fall back to prod bundle if it does not.

PR closes angular#449
ayazhafiz pushed a commit that referenced this issue Nov 25, 2019
VS Code Insider launches extension in debug mode by defaul, but users
install prod bundle so we have to check whether dev bundle exists, and
fall back to prod bundle if it does not.

PR closes #449
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants