Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

feat(@nguniversal/common): disable critical CSS inlining by default #2349

Merged
merged 1 commit into from
Oct 6, 2021
Merged

feat(@nguniversal/common): disable critical CSS inlining by default #2349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/common/clover/server/src/server-engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class Engine {
pathname,
options.htmlFilename,
);
const inlineCriticalCss = options.inlineCriticalCss !== false;
const inlineCriticalCss = options.inlineCriticalCss === true;

const customResourceLoader = new CustomResourceLoader(
origin,
Expand Down
4 changes: 2 additions & 2 deletions modules/common/engine/src/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface RenderOptions {
documentFilePath?: string;
/**
* Reduce render blocking requests by inlining critical CSS.
* Defaults to true.
* Defaults to false.
*/
inlineCriticalCss?: boolean;
/**
Expand Down Expand Up @@ -64,7 +64,7 @@ export class CommonEngine {
* render options
*/
async render(opts: RenderOptions): Promise<string> {
const { inlineCriticalCss = true } = opts;
const { inlineCriticalCss = false } = opts;

if (opts.publicPath && opts.documentFilePath && opts.url !== undefined) {
const url = new URL(opts.url);
Expand Down